Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] mm/mmap_lock: fix warning when CONFIG_TRACING is
 not defined
To:     Matthew Wilcox <willy@infradead.org>
CC:     <akpm@linux-foundation.org>, <linux-mm@kvack.org>,
        <linux-kernel@vger.kernel.org>
References: <20210531015527.49785-1-cuibixuan@huawei.com>
 <YLRDtBCPAYajOSqa@casper.infradead.org>
From:   Bixuan Cui <cuibixuan@huawei.com>
Message-ID: <ae21b203-0f31-7535-ef1b-9c5edd06fbc8@huawei.com>
Date:   Mon, 31 May 2021 11:34:19 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <YLRDtBCPAYajOSqa@casper.infradead.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 2021/5/31 10:02, Matthew Wilcox wrote:
>> Fix the warning: [-Wunused-function]
>> mm/mmap_lock.c:157:20: warning: ‘get_mm_memcg_path’ defined but not used
>>  static const char *get_mm_memcg_path(struct mm_struct *mm)
>>                     ^~~~~~~~~~~~~~~~~
> That seems like the wrong way to fix the warning.  Why not put it
> under an appropriate ifdef?
It's better than me, I will send a new patch.

Thanks
Bixuan Cui

>