Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2290475pxj; Sun, 30 May 2021 21:05:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxXbNOyklmxHzvQzwg9oN67Q5MdJbzFv6M9ItucPrOChHuirMW9ozZRNEJQSPh+9tlQUQKu X-Received: by 2002:a05:6402:170e:: with SMTP id y14mr14617787edu.367.1622433936436; Sun, 30 May 2021 21:05:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622433936; cv=none; d=google.com; s=arc-20160816; b=C4f8xxArjQQ7I6IY3ClnnfirCdHzMjApA7/WL7DN/OMBKl6N1Up/IQ0IzpH2CUv37p G0paIMAJ/m/kwTOo8/rsjWhcTd5hkJ93jt+BhhHfD0gFUUoMLl1da6zHbww/7WOa8/zy AdRQPnBdSLMZ9IIBHHVDzL5mLFHeQk+nJcnitIc0GG5TEPX8UKI+vjaJ8frc24h9T4qF H384j7t/6L3dsv5CBdo9o8QRso7yIxl/lxMagXfVyRBUtCNJRF1q4UrxiAq204XoYJfV jjhSdYN0h/Z8jIaZi9oOiBNDA6AerIPZWJJ+4WVazrzSN1S+533W8zn1mu42S/jYCKcI XMMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SmL+bBBl2uapk44DfeSKufF8SnX9xum47gJSalgfG9o=; b=WvGzB94uOfg408ZcIsyC7rWJcVWXLM2/iIMmxjElE1c1aR7CD8f1E5OeAFWdZqQYRL zjljvsdcZlBLUarebyeGz27+TiHThI0evj8tCQYFGp0LXBLjOMKViBgBjl//kN4fzAln /+Yhi2/gIb3E5m87PLhZS6xfSrAj1Zp+DeGjxeiFxVLzm/5Nf1EhhGKK+LrfKXlygyV+ iLe6ufpVLDHGD7mtBlDhNhkfomxVFwjtBW54NEzjyqOi92qv3FQLnPe4QSEB8gv+bsk1 EM+kaDnYa7xAWug4mlYpLq8NHZ5ssaJ0Ws98sW8Q85IXWPl+5oMI0rDr5k1bv2pepUzj ei/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VM8YtfKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i10si14465184ejd.683.2021.05.30.21.05.14; Sun, 30 May 2021 21:05:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VM8YtfKy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230084AbhEaEFg (ORCPT + 99 others); Mon, 31 May 2021 00:05:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:56412 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229475AbhEaEFe (ORCPT ); Mon, 31 May 2021 00:05:34 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1413E611EE; Mon, 31 May 2021 04:03:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622433835; bh=0xfMtsHewwb7fTSKcKv14cPltEk1ithOlhx+6gwiMWg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VM8YtfKyDimkBGOLI3jzbPADCGHY9togxkgw/t1OJMJA2/EzV9QKERn5fqR1/9ZBM 2VkbAULuFn67dcinY8YvPt9aSTfOwCD3OMfAmdOdATsGgQmlDYz+DnSq86GNczjch/ jHZF9i5WOPlctEss+1/B7yd+GY/zgo0728rj+KNPRryYFr+6z+gW8jExoB2Rzl/LTW vXnoMZEGyASpNtqOb/yP05BgodiXKKEb6VQ5ejhheI0ZgmzFsk/mWZPJPYFci2gPkE vM2QQI/dCeM0J0HcNECT+1muCQsp/Tg4DI3me/yqVGyYj14+P/A7yF1CBQ59BmTTWq knMP96zf2+otg== Date: Mon, 31 May 2021 09:33:52 +0530 From: Vinod Koul To: Yu Kuai Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 3/3] dmaengine: zynqmp_dma: Fix PM reference leak in zynqmp_dma_alloc_chan_resourc() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-4-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517081826.1564698-4-yukuai3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-05-21, 16:18, Yu Kuai wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Applied, thanks -- ~Vinod