Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2291449pxj; Sun, 30 May 2021 21:07:25 -0700 (PDT) X-Google-Smtp-Source: ABdhPJye6JJHyLPd91HwIhoCpbTgEYIf0NG9bzTyWxPfrWfrxABK9fylkoo2nzHl3aQki/hT4wyS X-Received: by 2002:a05:6638:38a8:: with SMTP id b40mr18982337jav.37.1622434044961; Sun, 30 May 2021 21:07:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622434044; cv=none; d=google.com; s=arc-20160816; b=M5HYyCHsvfzZnYhF7oqUNPM/egYOSM6JrVyqz/Dzwm/iHLql9aVN4jPQ78vDbhGc7i TEzMK06lJjGKMukxj/QJgT/KjDmo3G0ngCVIbj+G10HP7X+hqK3GIyU9fbEi77Q8gQeP XkFEmctlKQTDgm0HEWZraItMnGss/6oYSeHta6g5BLrk4W+tiX6aYWFGDAmCnkkEfodC 0t6Geg0XJsD1W+2eiyhJCmRf+r5UwJOBU2TTkAFR1ob4XiwuUcfvUExkVhTtqR8dNXRH dACAGekj3flLUQbTyg5c9hrGHCk269aAxgcopOFcnW/yDt4we8mM0hqkOrwzeYn6TFXt H3aQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=SmL+bBBl2uapk44DfeSKufF8SnX9xum47gJSalgfG9o=; b=B5aQryK8spFPKM9kGKTGjy9Zsth6hmWsE6ehelGdoR2qxLqrXTAItN6Pn4WcVVSCYC WByN0dzek1ItRWT5hwiPytw5DkwdaQ58YrsSldl9RsQPGle3HhsvzAKf4ulrsYvG5dap ltQ7R6jqEmxMcZo63KMzNXWdYYnWhTKLNznVF+71vPM0cavmiE0BuKpL/GW3vfhCpdTa H4BtEWJoeWBeLMhxRruWB2qUU9+mlvTC+S7mMc1t4RlvrIYRmOFYz7f/nOzrCP2VNR49 /1NmmyeWHWP2bbkgj3qqYgQqDuxY+qpjOQPDOvEb4mmEPatM6W5bFt6Auz9kuIdrH9Ge erTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YH4XE324; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 23si12678543iof.89.2021.05.30.21.07.11; Sun, 30 May 2021 21:07:24 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YH4XE324; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbhEaEFY (ORCPT + 99 others); Mon, 31 May 2021 00:05:24 -0400 Received: from mail.kernel.org ([198.145.29.99]:56300 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbhEaEFW (ORCPT ); Mon, 31 May 2021 00:05:22 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DD10F611AC; Mon, 31 May 2021 04:03:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622433823; bh=0xfMtsHewwb7fTSKcKv14cPltEk1ithOlhx+6gwiMWg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YH4XE324kuwVcxWwphHA9vmTHk3uOkBaY0gEBmL90Rkd2umcwWyJEcz4vBFw89xuo gaAw4gElZ2x9ARafnLx6MgO4gRUCZNy07c27Asx2k5ngrVqa6MjU5MS6FLxMgscq+N 86AyApEbCSXfmohHU2EExJ6P1RF5K39ZI7/GU6/Med5DJTFNwfms4UXieXq0Xqj7j5 7s8/lKiMcbYB6hBjxmvszUKm/S6x9vAhXieRTR6kfguTcRPgnwrHDCdtPKQDhetYN9 opAE80XSsBpPVHuoWo2X8iH+Fk5wTHhhCl4c3Xc5yaVo+/g3fDeF5+e4LF86piqwi/ XoySnNHa+7ltQ== Date: Mon, 31 May 2021 09:33:39 +0530 From: Vinod Koul To: Yu Kuai Cc: mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, michal.simek@xilinx.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, yi.zhang@huawei.com Subject: Re: [PATCH 1/3] dmaengine: stm32-mdma: fix PM reference leak in stm32_mdma_alloc_chan_resourc() Message-ID: References: <20210517081826.1564698-1-yukuai3@huawei.com> <20210517081826.1564698-2-yukuai3@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210517081826.1564698-2-yukuai3@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17-05-21, 16:18, Yu Kuai wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Applied, thanks -- ~Vinod