Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2296671pxj; Sun, 30 May 2021 21:18:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyH8KMwDZwS95NwCBy7Y4GyJ+bwesNUf18bmXOSpoS/jpsh5Z3Riqt2uVPPhoECzrXjU9Kr X-Received: by 2002:a6b:7948:: with SMTP id j8mr15353445iop.32.1622434713054; Sun, 30 May 2021 21:18:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622434713; cv=none; d=google.com; s=arc-20160816; b=r5qDjrGAT9465gDF5/NEXHmcXZTob8lDDE4BK4Omzcjap78Vk00jYBw3Dk95lcMHJN jpdjGl++8WD7IEA6hFGUuMQQbDguNKPfIwIPZSnls02bJDEdO3JzamKNUHfjvVZYJeN1 +50lK5i1Jex6Pu0PlOMtfGIRkhPERyjAcyie1AYBccJvl68VA/cNEX9Uegx1iY120Yzc tdyVvDPPBQMzXS82XM9Q3QLgp8b3X5mrg9R2iC1ZXCrMQMzLyiOX0/HxYv9rBDPFGGDU BFslHDyNIIRZkrHp/wvynH5Isiy3k+0woQsjpL6GcyEJhnP49vGFLMDYBvBRkkE4M22b Rfnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Q6raslAW9Qk7oNxW5lXPsC8hdpg56TNfgyRBUas4+m4=; b=LheDgK49ladhjtox11Z4xoQWtZDXx8+YDwLITVWmiHg7WlVSF/3T2yJ1gPFIsPuFc3 G47kzfGG6jD5AuBSCS9qdUsJshitT0N1jskxkWGM4bQJHAk6k0NlPQj7zGFcR0vfvn4m XX1C8RKbE+0oGRJAPfGnzPiqlypAdNBUA0qVKWGea+RxZygy/3AzUIFo5bbbdM+sJ/dY Gm7J70NVYGIxr20RC/w8SUQfq/zaCQHd5hr2pSJ4L5BJFAqe2K/B/EQRMhHcVE+BNO4Z zoraM0SWMT4sFHeNN/tLGKgA99J0DGVBlHP+iWBuH2YVtEyTvv08pwCO56MwdRqTniW/ 4uYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZSNt6RNU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j8si13410681ioo.10.2021.05.30.21.18.19; Sun, 30 May 2021 21:18:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZSNt6RNU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbhEaESU (ORCPT + 99 others); Mon, 31 May 2021 00:18:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:59168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbhEaEST (ORCPT ); Mon, 31 May 2021 00:18:19 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 16A4660FF0; Mon, 31 May 2021 04:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622434599; bh=WrrNcXLSHGAxtkDaYh0sooXVPLQWlfDXREfK1i3H/5E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZSNt6RNUzsFj9QqGharZZ/5OVOErMq24NUVJUMA3vcK9ZQIk2vk0cRcPTSD5Kz5hq LqMKAcCXBv2DaYPPefCkKDSfEuqesQUAwmHpqZT0fzecNe1OlS9kBfWSjftgezJL7R X0hJwwvahOCLHA2euDqqvAdkNGO1Cg/QvEUXpU5fLNyfg5zgZBry5snamtdexI5qCM att6IndNwPQgS5b/rTtayW+ISR9zx3HSgSx7vDdL052nfx/Z+G7mrdVvdXKZCzzW98 Yw6QeGZcNc4BLYOJ+anmQk3aEV7TDphNwmE2d5HALkwgJgjgxZWOl/xGNXw1JIsabD usLUFzXJfDAwQ== Date: Mon, 31 May 2021 09:46:36 +0530 From: Vinod Koul To: Zou Wei Cc: orsonzhai@gmail.com, baolin.wang7@gmail.com, zhang.lyra@gmail.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH -next] dmaengine: fix PM reference leak Message-ID: References: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1621601902-33697-1-git-send-email-zou_wei@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21-05-21, 20:58, Zou Wei wrote: > pm_runtime_get_sync will increment pm usage counter even it failed. > Forgetting to putting operation will result in reference leak here. > Fix it by replacing it with pm_runtime_resume_and_get to keep usage > counter balanced. Please rebase and submit per driver.. I have already applied few fixes for this and rejected few -- ~Vinod