Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210531030550.1708816-1-yangyingliang@huawei.com>
In-Reply-To: <20210531030550.1708816-1-yangyingliang@huawei.com>
From:   Hyunchul Lee <hyc.lee@gmail.com>
Date:   Mon, 31 May 2021 14:38:42 +0900
Message-ID: <CANFS6bbZysgZ2Wv7_FqmeBC0e34h5uiBLFdeiDvOxHFd2XGTSg@mail.gmail.com>
Subject: Re: [PATCH -next v2] cifsd: check return value of ksmbd_vfs_getcasexattr()
 correctly
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        linux-cifsd-devel <linux-cifsd-devel@lists.sourceforge.net>,
        linux-cifs <linux-cifs@vger.kernel.org>,
        Namjae Jeon <namjae.jeon@samsung.com>,
        Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
        Steve French <sfrench@samba.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

2021=EB=85=84 5=EC=9B=94 31=EC=9D=BC (=EC=9B=94) =EC=98=A4=ED=9B=84 12:01, =
Yang Yingliang <yangyingliang@huawei.com>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
>
> If ksmbd_vfs_getcasexattr() returns -ENOMEM, stream_buf is NULL,
> it will cause null-ptr-deref when using it to copy memory. So we
> need check the return value of ksmbd_vfs_getcasexattr() by comparing
> with 0.
>
> Fixes: f44158485826 ("cifsd: add file operations")
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> v2:
>   Handle the case ksmbd_vfs_getcasexattr() returns 0.
> ---
>  fs/cifsd/vfs.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/fs/cifsd/vfs.c b/fs/cifsd/vfs.c
> index 97d5584ec870..2a9cc0bc7726 100644
> --- a/fs/cifsd/vfs.c
> +++ b/fs/cifsd/vfs.c
> @@ -274,7 +274,6 @@ static int ksmbd_vfs_stream_read(struct ksmbd_file *f=
p, char *buf, loff_t *pos,
>  {
>         ssize_t v_len;
>         char *stream_buf =3D NULL;
> -       int err;
>
>         ksmbd_debug(VFS, "read stream data pos : %llu, count : %zd\n",
>                     *pos, count);
> @@ -283,10 +282,9 @@ static int ksmbd_vfs_stream_read(struct ksmbd_file *=
fp, char *buf, loff_t *pos,
>                                        fp->stream.name,
>                                        fp->stream.size,
>                                        &stream_buf);
> -       if (v_len =3D=3D -ENOENT) {
> +       if ((int)v_len <=3D 0) {
>                 ksmbd_err("not found stream in xattr : %zd\n", v_len);
> -               err =3D -ENOENT;
> -               return err;
> +               return v_len =3D=3D 0 ? -ENOENT : (int)v_len;

How about making ksmbd_vfs_getcasexattr return -ENONENT instead of
returning 0 to
remove duplicate error handling code?

Thanks,
Hyunchul

>         }
>
>         memcpy(buf, &stream_buf[*pos], count);
> @@ -415,9 +413,9 @@ static int ksmbd_vfs_stream_write(struct ksmbd_file *=
fp, char *buf, loff_t *pos,
>                                        fp->stream.name,
>                                        fp->stream.size,
>                                        &stream_buf);
> -       if (v_len =3D=3D -ENOENT) {
> +       if ((int)v_len <=3D 0) {
>                 ksmbd_err("not found stream in xattr : %zd\n", v_len);
> -               err =3D -ENOENT;
> +               err =3D v_len =3D=3D 0 ? -ENOENT : (int)v_len;
>                 goto out;
>         }
>
> --
> 2.25.1
>