Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1622113652-56646-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1622113652-56646-1-git-send-email-zou_wei@huawei.com>
From:   Shengjiu Wang <shengjiu.wang@gmail.com>
Date:   Mon, 31 May 2021 15:14:45 +0800
Message-ID: <CAA+D8AOzEUfbCCjhJbEwXav_WWqn_aPX-0krJQ_bOJQiDJu58A@mail.gmail.com>
Subject: Re: [PATCH -next] ASoC: imx-rpmsg: fix platform_no_drv_owner.cocci warnings
To:     Zou Wei <zou_wei@huawei.com>
Cc:     Timur Tabi <timur@kernel.org>,
        Nicolin Chen <nicoleotsuka@gmail.com>,
        Xiubo Li <Xiubo.Lee@gmail.com>,
        Fabio Estevam <festevam@gmail.com>,
        Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.com>, Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Sascha Hauer <kernel@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, May 27, 2021 at 6:48 PM Zou Wei <zou_wei@huawei.com> wrote:
>
> ./sound/soc/fsl/imx-rpmsg.c:140:3-8: No need to set .owner here. The core will do it.
>
>  Remove .owner field if calls are used which set it automatically
>
> Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Acked-by: Shengjiu Wang <shengjiu.wang@gmail.com>

> ---
>  sound/soc/fsl/imx-rpmsg.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/sound/soc/fsl/imx-rpmsg.c b/sound/soc/fsl/imx-rpmsg.c
> index 5a9a470..f0cae8c 100644
> --- a/sound/soc/fsl/imx-rpmsg.c
> +++ b/sound/soc/fsl/imx-rpmsg.c
> @@ -137,7 +137,6 @@ static int imx_rpmsg_probe(struct platform_device *pdev)
>  static struct platform_driver imx_rpmsg_driver = {
>         .driver = {
>                 .name = "imx-audio-rpmsg",
> -               .owner = THIS_MODULE,
>                 .pm = &snd_soc_pm_ops,
>         },
>         .probe = imx_rpmsg_probe,
> --
> 2.6.2
>