Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2392680pxj; Mon, 31 May 2021 00:36:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwo5KLvMNtIo/gbuP4kQQ+jud6j1YwwDYCinWst2xBLJkTBLGoxXKsadgrcisvIDcMmkGWl X-Received: by 2002:a17:906:77dc:: with SMTP id m28mr21173419ejn.23.1622446596266; Mon, 31 May 2021 00:36:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622446596; cv=none; d=google.com; s=arc-20160816; b=s1qspAGbfDLphf0BKrq3LjzfUqeBEyqK7sdTTmxd59M5qwUd1QIscM8JwHXekmSaRL ioX+cHw0Gqj91d5Zjbq8gSFTV+Jh0dP6FoiYiUz+VQwsITnPCoWLPa7d799QsIa6bfge 3dMGrzJIZA6Y2nhpg+vsnIYj1lD3Hak7ddXQtMt7TpgD8l933uXVjmaifdd6hpF95oeF EYWikfthihRzXrkLTT5Oi3YjOci2h9Ws/aB3ArD3RcD0+KpyBh4FkWprzCE3ciuFnUhk VZg/UBxESFsJA4XmTQ2pGnaXCfx57iQre4BiX/IK8uQrCpY3nxXKwRO2g/+EltZhrWz3 VsKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:content-language :in-reply-to:mime-version:user-agent:date:message-id:from:references :cc:to:subject:dmarc-filter:sender:dkim-signature; bh=wDQQ376bN5sF92/v8P8tqDT6yjiu711CYrdBMl+n7Xs=; b=oQuNL9zSiUrT2hakUOtF1lMf0Veg7Fhv/TxVu1KHn7jKGf9ut7KhbHrEG+FFXaqlkJ mLuq16cV/dLbV7MptDQvOrcN64Lu7hQT7wHkQo96lJa6UwO7Of+NHmPEPLNmhTHOZ6JJ 4odVXFBYdXsvyIDGBxqattZ1ox1Z+nQsN3Uhi+Ref9Lttul5fN5Grq8j7HCz7rG16frk iTtuklz0wPOl+Kn03hsm4pompt8qz2suJCzscCASs74iSA/84IUJ70R8rJDHfFLtBYmK hX0/mV5qke7wonQjKqI7fuzMf9TA5ypu2S79gsxL3bZ1N2nOOhIqKVxhO2aYG/wW36t2 b5Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qMPS6VCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r21si13785623ejo.341.2021.05.31.00.36.13; Mon, 31 May 2021 00:36:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@mg.codeaurora.org header.s=smtp header.b=qMPS6VCW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230375AbhEaHgQ (ORCPT + 99 others); Mon, 31 May 2021 03:36:16 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:61218 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230396AbhEaHfu (ORCPT ); Mon, 31 May 2021 03:35:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1622446451; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=wDQQ376bN5sF92/v8P8tqDT6yjiu711CYrdBMl+n7Xs=; b=qMPS6VCWnxHS8+qW/y1ECxSZxjSl0UGfPWeAktzaqEk+CNQ3CLvH3syNrIEIwGT9JMPVxrT2 VzTDOsBNbziC5/PWxhtuITqINAnCxhlA9SDdeY99qyUhrS2hcTJVXUsMBcs2tyY83aLwRJ7y yYZyxhKh1bIkc0g5e6/TqdNKtIw= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60b4916dea2aacd7296040ba (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 31 May 2021 07:34:05 GMT Sender: akhilpo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 47E94C43147; Mon, 31 May 2021 07:34:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=2.0 tests=ALL_TRUSTED,BAYES_00, NICE_REPLY_A,SPF_FAIL,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from [192.168.1.105] (unknown [117.210.184.158]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akhilpo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 08292C43460; Mon, 31 May 2021 07:33:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 08292C43460 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=akhilpo@codeaurora.org Subject: Re: [PATCH v2 3/8] drm/msm/a6xx: fix incorrectly set uavflagprd_inv field for A650 To: Jonathan Marek , freedreno@lists.freedesktop.org Cc: Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Jordan Crouse , Eric Anholt , Sai Prakash Ranjan , Sharat Masetty , Douglas Anderson , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list References: <20210513171431.18632-1-jonathan@marek.ca> <20210513171431.18632-4-jonathan@marek.ca> From: Akhil P Oommen Message-ID: <85cd323b-90a2-9324-5696-fc80cf667827@codeaurora.org> Date: Mon, 31 May 2021 13:03:57 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 MIME-Version: 1.0 In-Reply-To: <20210513171431.18632-4-jonathan@marek.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/13/2021 10:43 PM, Jonathan Marek wrote: > Value was shifted in the wrong direction, resulting in the field always > being zero, which is incorrect for A650. > > Fixes: d0bac4e9cd66 ("drm/msm/a6xx: set ubwc config for A640 and A650") > Signed-off-by: Jonathan Marek > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > index 727d111a413f..45a6a0fce7d7 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c > @@ -489,7 +489,7 @@ static void a6xx_set_ubwc_config(struct msm_gpu *gpu) > rgb565_predicator << 11 | amsbc << 4 | lower_bit << 1); > gpu_write(gpu, REG_A6XX_TPL1_NC_MODE_CNTL, lower_bit << 1); > gpu_write(gpu, REG_A6XX_SP_NC_MODE_CNTL, > - uavflagprd_inv >> 4 | lower_bit << 1); > + uavflagprd_inv << 4 | lower_bit << 1); > gpu_write(gpu, REG_A6XX_UCHE_MODE_CNTL, lower_bit << 21); > } > > Reviewed-by: Akhil P Oommen -Akhil.