Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 May 2021 14:09:59 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Yang Li <yang.lee@linux.alibaba.com>
Cc:     kishon@ti.com, linux-phy@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: ti: Fix an error code in wiz_probe()
Message-ID: <YLSg3z3hYsT/QQ1n@vkoul-mobl.Dlink>
References: <1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1621939832-65535-1-git-send-email-yang.lee@linux.alibaba.com>
Precedence: bulk

On 25-05-21, 18:50, Yang Li wrote:
> When the code execute this if statement, the value of ret is 0. 
> However, we can see from the dev_err() log that the value of 
> ret should be -EINVAL.
> 
> Clean up smatch warning:
> 
> drivers/phy/ti/phy-j721e-wiz.c:1216 wiz_probe() warn: missing error code
> 'ret'

Single line is fine for this

> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Fixes: 'commit c9f9eba06629 ("phy: ti: j721e-wiz: Manage
> typec-gpio-dir")'

Please dont split to two lines for fixes tag

> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>

I have fixed while applying so Applied, thanks

> ---
>  drivers/phy/ti/phy-j721e-wiz.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
> index 9eb6d37..126f5b8 100644
> --- a/drivers/phy/ti/phy-j721e-wiz.c
> +++ b/drivers/phy/ti/phy-j721e-wiz.c
> @@ -1212,6 +1212,7 @@ static int wiz_probe(struct platform_device *pdev)
>  
>  		if (wiz->typec_dir_delay < WIZ_TYPEC_DIR_DEBOUNCE_MIN ||
>  		    wiz->typec_dir_delay > WIZ_TYPEC_DIR_DEBOUNCE_MAX) {
> +			ret = -EINVAL;
>  			dev_err(dev, "Invalid typec-dir-debounce property\n");
>  			goto err_addr_to_resource;
>  		}
> -- 
> 1.8.3.1

-- 
~Vinod