Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 May 2021 10:47:20 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc:     linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Manivannan Sadhasivam <mani@kernel.org>,
        Thomas Kopp <thomas.kopp@microchip.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 1/2] can: mcp251xfd: Try to get crystal clock rate
 from property
Message-ID: <20210531084720.6xql2r4uhp6ruzl6@pengutronix.de>
References: <20210526193327.70468-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="2berr7nn6ppdwg42"
Content-Disposition: inline
In-Reply-To: <20210526193327.70468-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk


--2berr7nn6ppdwg42
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 26.05.2021 22:33:26, Andy Shevchenko wrote:
> In some configurations, mainly ACPI-based, the clock frequency of the dev=
ice
> is supplied by very well established 'clock-frequency' property. Hence, t=
ry
> to get it from the property at last if no other providers are available.
>=20
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: new patch
>  drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c b/drivers/net=
/can/spi/mcp251xfd/mcp251xfd-core.c
> index e0ae00e34c7b..e42f87c3f2ec 100644
> --- a/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
> +++ b/drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c
> @@ -2856,7 +2856,7 @@ static int mcp251xfd_probe(struct spi_device *spi)
>  	struct gpio_desc *rx_int;
>  	struct regulator *reg_vdd, *reg_xceiver;
>  	struct clk *clk;
> -	u32 freq;
> +	u32 freq, rate;
>  	int err;
> =20
>  	if (!spi->irq)
> @@ -2883,11 +2883,16 @@ static int mcp251xfd_probe(struct spi_device *spi)
>  		return dev_err_probe(&spi->dev, PTR_ERR(reg_xceiver),
>  				     "Failed to get Transceiver regulator!\n");
> =20
> -	clk =3D devm_clk_get(&spi->dev, NULL);
> +	/* Always ask for fixed clock rate from a property. */
> +	device_property_read_u32(&spi->dev, "clock-frequency", &rate);

what about error handling....?

> +
> +	clk =3D devm_clk_get_optional(&spi->dev, NULL);
>  	if (IS_ERR(clk))
>  		return dev_err_probe(&spi->dev, PTR_ERR(clk),
>  				     "Failed to get Oscillator (clock)!\n");
>  	freq =3D clk_get_rate(clk);
> +	if (freq =3D=3D 0)
> +		freq =3D rate;

=2E.. this means we don't fail if there is neither a clk nor a
clock-frequency property. I've send a v3 to fix this.

> =20
>  	/* Sanity check */
>  	if (freq < MCP251XFD_SYSCLOCK_HZ_MIN ||
> --=20
> 2.30.2
>=20
>

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--2berr7nn6ppdwg42
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEK3kIWJt9yTYMP3ehqclaivrt76kFAmC0opUACgkQqclaivrt
76kAVAgAqxbBCmlQAhoPyB073hbARvhTkRMi7Q//Py9WHyiwEPwLFfAvTGN/7sFr
R7B09kzNaahBQ+bX/BclI5UcsGva5QgGouXJDz8MF/ilXskAeqzVhw4GUJbVj2EJ
CYVk1Hu4QebsFgUH0+g8PPd4R6FxK3t+xPmG9KlyHy6DC+zTCl8AK8PbvJcKMdHH
s1mM09kknfCCUVlT8xyUifEYY9OyPj+OHfsxMiRzxqRKx+ep5/wmgy2BJ/C0I4YC
2cU044bLKbcNd21nduqrt8uD9+QBL4J10MNhGZW3J3nonzmXiEJ48vLOLXLZqKAR
AQC/CFipnfIvuy7Ctupd0xLvmMcH7Q==
=58nX
-----END PGP SIGNATURE-----

--2berr7nn6ppdwg42--