Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2437925pxj; Mon, 31 May 2021 02:05:00 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxkUMPzk+hn7c+ovivxFVQbedg/icZTz/nffZTckhpOnFKZDx5PlXH+UNsXqRDl6Y6ilkWf X-Received: by 2002:a05:6402:42cd:: with SMTP id i13mr24165241edc.34.1622451900092; Mon, 31 May 2021 02:05:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622451900; cv=none; d=google.com; s=arc-20160816; b=C2+DiyDsdgvl1vI0YhMgbSbZa1qr/B6eR9VWyNOT5nGMPLNU+WQ8FJOarcN3lNAl9K +uwz5whti59jj+UDMmYj8y0BGMsrJcbp2pjhLkSvZKJD2vQChTYVZYc+OK+qJoetbCIc XNfI4PrNs7Pq9sWlKenpewiEqiw9pCdJMrRRAze9T9H2qBrY4105nw4Y5GzJEmCoA6C2 /HqTgDS/KXp7HqyUvyWAz9t+i8gpjUCK83jkPgNtaQzxjCk2kCAQYIrfYPssZn3Xe18c Tc3z922hXHkBJxHgnLVSPNg/oIIF5wKyY2+nQbxpoeEF2QQbU3BeoejTK1xHsOSw8Rl7 1d5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=HPFOhFJ1RYN7Mkv8HTm6LVjnDdbgpjNPzn/PlmfWplw=; b=xa99lUnoB7tH/PJdbLOh2U19mUgzG5PavarxIYU60kZjvQKJ/ZCzAOvmflofqPnmig d87eEWiUPzDFWlKErbw5xnCL39+vFvqJJpBvJvKv3T8t05usULjgFCkKwjR0PfHnTois 4UNeJ0kX7MeQ/WcL96ZH2n4SAg5r6TUZeYAX/XezP6WcE2W7bnBY8QLFqGgzXjYLsqtd 8BwUCpyvXNB8o62gSnfxNWWSsqLEcxLRcXm7Tn5mLxrahmfdlGdgAAOwOk7BxgyAcLCQ eK0j+Z8lrjwPLgRW2uKQ/VDejw6zOaIY0hX7AoCka501PlgWH36M6QUOXkzqSSxokmwD aw2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jv5si10462255ejc.375.2021.05.31.02.04.37; Mon, 31 May 2021 02:05:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=canonical.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230429AbhEaJE6 (ORCPT + 99 others); Mon, 31 May 2021 05:04:58 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:34423 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhEaJE4 (ORCPT ); Mon, 31 May 2021 05:04:56 -0400 Received: from 111-240-143-199.dynamic-ip.hinet.net ([111.240.143.199] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lndpI-0004qd-Hx; Mon, 31 May 2021 09:03:13 +0000 From: chris.chiu@canonical.com To: Jes.Sorensen@gmail.com, kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org Cc: code@reto-schneider.ch, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Chris Chiu Subject: [PATCH 1/2] rtl8xxxu: unset the hw capability HAS_RATE_CONTROL Date: Mon, 31 May 2021 17:02:53 +0800 Message-Id: <20210531090254.86830-2-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20210531090254.86830-1-chris.chiu@canonical.com> References: <20210531090254.86830-1-chris.chiu@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Chris Chiu The HAS_RATE_CONTROL hw capability needs to be unset for the rate control of mac80211 to work. Since the ieee80211_start_tx_ba_session is started by the method .get_rate of rate_control_ops. We need to unset it so the ampdu can be handled by mac80211. Signed-off-by: Chris Chiu --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 9ff09cf7eb62..4cf13d2f86b1 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -6678,7 +6678,6 @@ static int rtl8xxxu_probe(struct usb_interface *interface, /* * The firmware handles rate control */ - ieee80211_hw_set(hw, HAS_RATE_CONTROL); ieee80211_hw_set(hw, AMPDU_AGGREGATION); wiphy_ext_feature_set(hw->wiphy, NL80211_EXT_FEATURE_CQM_RSSI_LIST); -- 2.20.1