Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 May 2021 11:14:49 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Dmitry Osipenko <digetx@gmail.com>
Cc:     Jonathan Hunter <jonathanh@nvidia.com>,
        Agneli <poczt@protonmail.ch>, Paul Fertser <fercerpav@gmail.com>,
        Svyatoslav Ryhel <clamor95@gmail.com>,
        linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 04/10] ARM: tegra: Add reg property to Tegra20 EMC
 table device-tree nodes
Message-ID: <YLSpCXNtut3z8U9a@orome.fritz.box>
References: <20210510202600.12156-1-digetx@gmail.com>
 <20210510202600.12156-5-digetx@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="3GTNXXpnqAELcLjv"
Content-Disposition: inline
In-Reply-To: <20210510202600.12156-5-digetx@gmail.com>
User-Agent: Mutt/2.0.6 (98f8cb83) (2021-03-06)
Precedence: bulk


--3GTNXXpnqAELcLjv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 10, 2021 at 11:25:54PM +0300, Dmitry Osipenko wrote:
> The reg property is now specified for the emc-tables nodes in the Tegra20
> device-tree binding. Add reg property to the EMC table device-tree nodes
> of Tegra20 board device-trees in order to silence dt_binding_check warning
> about the missing property.
>=20
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  arch/arm/boot/dts/tegra20-acer-a500-picasso.dts | 4 ++++
>  arch/arm/boot/dts/tegra20-paz00.dts             | 1 +
>  2 files changed, 5 insertions(+)

In retrospect we should've just used "reg" in the first place rather
than adding the custom "nvidia,ram-code". It's a bit redundant to have
both of them with the same value. I wonder if we should deprecate the
use of "nvidia,ram-code" and at least make the code look at the "reg"
property first and only fall back to "nvidia,ram-code" if "reg" does
not exist. We probably won't ever be able to get rid of the fallback
for backwards-compatibility reasons, but at least that would make the
intent a bit clearer.

Thierry

--3GTNXXpnqAELcLjv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmC0qQcACgkQ3SOs138+
s6E4ZA/+L3pXjr7LDZIYSuiOI6J1hx43F7MT2JrtA5uvDEqqAYepFuL1NdtKDE4F
cWat3iTYKZkTteOQZ5KMRjO30V/81aCXWeqIQxiIiqYiER1XiuBVqFT7xE29AvEU
jSRuRkY1Co5Pubew1BfvxrsrB/1x7Dtpl7VL5TNoFUttlE4dJRjjnCfdPM8LtNFm
53fZBmqqhG5NLK7lgqCMXmqVnJKXbOGavxbfK1o+sUbujTTrMqzKO9ZgOZFIfWFA
EgRZOICPkAnM+eJLCUKaiXXIMXPlhf21V87VV783p2Ka/Gc7TyEv3bzeetBHaDjP
0tLVKYYB8764N9rNUnvx7xzuQA8Y8UP2Sf8KqJouziK1X7ioHv+IAJXBAeImpNYh
+X+pFqCqY6OZhP0naOGB2jvLX/hV0hXuy262+BMowY2xl/S8AooAjC6BBDN4QKTL
V5lPZwAGrjpoTSAk7WybTP6mDOzW0Gdkg1QZwgCRKcbBPfnxm4Nfd3+stXT5EcH7
FDsDgOlKyYKEor9zbia2igKEJIbfTroWF5HzhH8FQ19zIixIhNXCkTmAUNWw0+/c
HNwSxp1lhh/0lGeY590/VFyyqzlrOKW2yxap/yJ0qHp/wbYEJaI3+D/UugT6WMvr
8fiNS/tYDmYsmZSepjG5c07kQuQHyirGrYEWO5I/mmYYd8S7qhA=
=AVK1
-----END PGP SIGNATURE-----

--3GTNXXpnqAELcLjv--