Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: kAm0TQu2P+GRsG59E1wd3S/aZ1i/l1eOQy7/lyHWbpR2F9mGZL1YI+tKzPLIqrZL1TmxaMYpjU
 t0AMVurKb1wQ==
IronPort-SDR: oFTtw+LeyZUQE5FA8J3xvQs+G01ya/918el9293q9EmcOFvWzuBuH83b8Spnm/+ueHniTZh7pQ
 xyo/bnvkWE7w==
Date:   Mon, 31 May 2021 12:58:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Marc Kleine-Budde <mkl@pengutronix.de>
Cc:     linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Manivannan Sadhasivam <mani@kernel.org>,
        Thomas Kopp <thomas.kopp@microchip.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH v2 1/2] can: mcp251xfd: Try to get crystal clock rate
 from property
Message-ID: <YLSzRdpp9EWsLeFy@smile.fi.intel.com>
References: <20210526193327.70468-1-andriy.shevchenko@linux.intel.com>
 <20210531084720.6xql2r4uhp6ruzl6@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210531084720.6xql2r4uhp6ruzl6@pengutronix.de>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
Precedence: bulk

On Mon, May 31, 2021 at 10:47:20AM +0200, Marc Kleine-Budde wrote:
> On 26.05.2021 22:33:26, Andy Shevchenko wrote:
> > In some configurations, mainly ACPI-based, the clock frequency of the device
> > is supplied by very well established 'clock-frequency' property. Hence, try
> > to get it from the property at last if no other providers are available.

> >  		return dev_err_probe(&spi->dev, PTR_ERR(reg_xceiver),
> >  				     "Failed to get Transceiver regulator!\n");
> >  
> > -	clk = devm_clk_get(&spi->dev, NULL);
> > +	/* Always ask for fixed clock rate from a property. */
> > +	device_property_read_u32(&spi->dev, "clock-frequency", &rate);
> 
> what about error handling....?

Not needed, but rate should be assigned to 0, which is missed.

> > +	clk = devm_clk_get_optional(&spi->dev, NULL);
> >  	if (IS_ERR(clk))
> >  		return dev_err_probe(&spi->dev, PTR_ERR(clk),
> >  				     "Failed to get Oscillator (clock)!\n");
> >  	freq = clk_get_rate(clk);
> > +	if (freq == 0)
> > +		freq = rate;
> 
> ... this means we don't fail if there is neither a clk nor a
> clock-frequency property.

The following will check for it (which is already in the code)

  if (freq <= MCP251XFD_SYSCLOCK_HZ_MAX / MCP251XFD_OSC_PLL_MULTIPLIER) {

> I've send a v3 to fix this.

You mean I have to send v3?
Sure!


-- 
With Best Regards,
Andy Shevchenko