Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 31 May 2021 12:39:54 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Qiheng Lin <linqiheng@huawei.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, x86@kernel.org,
        hpa@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared
 extern
Message-ID: <YLS8+gMRp62s4WEY@zn.tnic>
References: <20210531031009.21737-1-linqiheng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20210531031009.21737-1-linqiheng@huawei.com>
Precedence: bulk

> Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern

The condensed patch description in the subject line should start with a
uppercase letter and should be written in imperative tone.

Also, the subject is wrong. Hint: "declaration" vs "definition".

On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote:
> The function declaration in kprobes.h is already marked extern, thus its
> definition should not have the keyword.
>
> This quiets the following sparse warning:
>  function 'arch_unoptimize_kprobes' with external linkage has definition

This sounds like you're fixing something just because some tool
complains and not because there's a real problem you're fixing.

Please rewrite your commit messages to state what the problem is and
why you're fixing that problem. The tool output can be used to say
something along the lines of "this problem was caught by this tool" but
not as "see, tool X complains and creates a warning and I must fix that
warning immediately."

Ok?

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette