Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: m5MIFJt4rpb+cdYmkkYmRVvhAPXZIpatJD4bDdpQhI/P+zuzIKrA699Q8pfEO8RgiGHdbugXgo
 e3qISxMpBm0w==
IronPort-SDR: CjjbPz5fMAuEqn0ZIyienNP5xgz4ay/aGLJGaCHoHm1ho8HO0ZKuk14puks00OFegbtWm8iAmh
 sajrjvAwN1Xw==
Date:   Mon, 31 May 2021 15:33:52 +0300
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Jun Li <jun.li@nxp.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Hans de Goede <hdegoede@redhat.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] usb: typec: mux: Remove requirement for the
 "orientation-switch" device property
Message-ID: <YLTXsKoe9JTKp43f@kuha.fi.intel.com>
References: <20210526153548.61276-1-heikki.krogerus@linux.intel.com>
 <20210526153548.61276-3-heikki.krogerus@linux.intel.com>
 <VI1PR04MB59350F5BC9129F9E0B21773889229@VI1PR04MB5935.eurprd04.prod.outlook.com>
 <YLSPLxfyavO+AkLY@kuha.fi.intel.com>
 <YLSW0IoHdnzRSzUW@kuha.fi.intel.com>
 <YLSdptmScGo5TJ1D@kuha.fi.intel.com>
 <VI1PR04MB5935F74E297A467D846AADEC893F9@VI1PR04MB5935.eurprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <VI1PR04MB5935F74E297A467D846AADEC893F9@VI1PR04MB5935.eurprd04.prod.outlook.com>
Precedence: bulk

> > > Oh no. This patch just landed into Greg's usb-next. I'll prepare the
> > > revert. I'm sorry about this.
> > 
> > Actually, if we always need that extra (boolean) device property to identify
> > the device class when OF graph is used, 
> 
> Looks like yes, as we need a way to know if the current fwnode
> is for the target device we are looking for, to return probe
> defer correctly.
> 
> > shouldn't we just do that always
> > in fwnode_graph_devcon_match()?
> 
> This depends on if we want to limit this to be a boolean property
> (to mark this is the target fwnode), or make it to be more generic
> so user can define it in its ->match().
> 
> Now there are only 2 users of it, role switch and typec mux, both work
> as a boolean property for con_id.


OK. Let's leave to the users for now.

thanks,

-- 
heikki