Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp2690080pxj; Mon, 31 May 2021 08:19:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn2LTRa0bOZUgwES7g81u5+RB/OsgtKFp9mniUdRmMCRWV/vyVIMUBifVIg5/4NrCPVR5L X-Received: by 2002:a5e:9907:: with SMTP id t7mr17390819ioj.155.1622474383022; Mon, 31 May 2021 08:19:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622474383; cv=none; d=google.com; s=arc-20160816; b=DMlwgKiX9DG8Y2qokinRQR1EoKJwWUINcX17FfsuVRb3PcQw1MNd4S1HyM0L23cWCB mlxhI52UusY3XLQmxpJBtulWshPvOR/31gsbcerthKMzqFaSDVuzIbro2dZFd9DtnzaP UKsYWLZfQ6asK+4jCwqsHbg/gefxFQi59VYY5I0IANwLLvIComxdA+xlPlojXNOBpCTK wtcYnQmoJmzZkm0C4+TXsefJnaSTBwbugbuDZyy3+EXpg41KMCZ/W/o/7ycIYPAuFT2W qwfcTKy1up8NhqmNXZKCskRFNA02XWGTo53KmzquVJn94yeBcdLlkx6uDJwFn6JzrXwz 9WaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g7KkZvaNfsayHsSh2BCdsWGrfvAYPIFYB4MlNTwIiSQ=; b=wu51KCWckSCKqPhG8UVNT1YmYXs/oPamxr/hU2HgyUN+eD2rp1XAT/Cd1ZksSL2nha 9n8oTbf0lMkiISVUXIrBPMnCSlt1JwUEYPJSaPyTfmtT7Z2JftTUeXDVhZ5q2qoGqtEL 7AwpqXObFPWYKqMViitA/4X8rbUiwLsvYGImC/5+57nQBgBAzru1gEVc1dKUH8hKOGK+ 0xsvdMDcAlNgsSwl1FQpcEb+S/4evRHhpKr93Jr/EmGBS4DCNwwDQ74WcE8jxTfWhlw1 OmXDgxfYh1UYH73/kikMgmdXBIN2HigqAdcN1DuqnxjgHqQYZznj7PYwJ3wgpdqrURsH lyYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ar3+hJZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q7si13094984jaj.88.2021.05.31.08.19.29; Mon, 31 May 2021 08:19:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ar3+hJZ3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232191AbhEaPUg (ORCPT + 99 others); Mon, 31 May 2021 11:20:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:43306 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233781AbhEaOPj (ORCPT ); Mon, 31 May 2021 10:15:39 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C493C619A1; Mon, 31 May 2021 13:42:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1622468571; bh=SLvqaojeofwp8GZw65DhfTi37SwMU3e5Yhve4mFHEco=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ar3+hJZ3TzM5Mis9Wg0tTa3kijCVn1H4LMQFArObMWAzHAAHG4DiH3rg6zZsKuyfb DMwsmNatPDPZcAsM26BXhgGLgqCCDGJMhLeP1nwLghrVuERkHHK4cjWJP8CiuI6El6 R4OWmRqiiz4/0yl6V5ER44qI0GGIsL7J6MMKoCfE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+636c58f40a86b4a879e7@syzkaller.appspotmail.com, Dongliang Mu Subject: [PATCH 5.4 040/177] misc/uss720: fix memory leak in uss720_probe Date: Mon, 31 May 2021 15:13:17 +0200 Message-Id: <20210531130649.313099268@linuxfoundation.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210531130647.887605866@linuxfoundation.org> References: <20210531130647.887605866@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dongliang Mu commit dcb4b8ad6a448532d8b681b5d1a7036210b622de upstream. uss720_probe forgets to decrease the refcount of usbdev in uss720_probe. Fix this by decreasing the refcount of usbdev by usb_put_dev. BUG: memory leak unreferenced object 0xffff888101113800 (size 2048): comm "kworker/0:1", pid 7, jiffies 4294956777 (age 28.870s) hex dump (first 32 bytes): ff ff ff ff 31 00 00 00 00 00 00 00 00 00 00 00 ....1........... 00 00 00 00 00 00 00 00 00 00 00 00 03 00 00 00 ................ backtrace: [] kmalloc include/linux/slab.h:554 [inline] [] kzalloc include/linux/slab.h:684 [inline] [] usb_alloc_dev+0x32/0x450 drivers/usb/core/usb.c:582 [] hub_port_connect drivers/usb/core/hub.c:5129 [inline] [] hub_port_connect_change drivers/usb/core/hub.c:5363 [inline] [] port_event drivers/usb/core/hub.c:5509 [inline] [] hub_event+0x1171/0x20c0 drivers/usb/core/hub.c:5591 [] process_one_work+0x2c9/0x600 kernel/workqueue.c:2275 [] worker_thread+0x59/0x5d0 kernel/workqueue.c:2421 [] kthread+0x178/0x1b0 kernel/kthread.c:292 [] ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:294 Fixes: 0f36163d3abe ("[PATCH] usb: fix uss720 schedule with interrupts off") Cc: stable Reported-by: syzbot+636c58f40a86b4a879e7@syzkaller.appspotmail.com Signed-off-by: Dongliang Mu Link: https://lore.kernel.org/r/20210514124348.6587-1-mudongliangabcd@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Greg Kroah-Hartman --- drivers/usb/misc/uss720.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/misc/uss720.c +++ b/drivers/usb/misc/uss720.c @@ -736,6 +736,7 @@ static int uss720_probe(struct usb_inter parport_announce_port(pp); usb_set_intfdata(intf, pp); + usb_put_dev(usbdev); return 0; probe_abort: