Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2992804AbWKAUYm (ORCPT ); Wed, 1 Nov 2006 15:24:42 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S2992803AbWKAUYm (ORCPT ); Wed, 1 Nov 2006 15:24:42 -0500 Received: from wohnheim.fh-wedel.de ([213.39.233.138]:4840 "EHLO wohnheim.fh-wedel.de") by vger.kernel.org with ESMTP id S2992801AbWKAUYl (ORCPT ); Wed, 1 Nov 2006 15:24:41 -0500 Date: Wed, 1 Nov 2006 21:24:00 +0100 From: =?iso-8859-1?Q?J=F6rn?= Engel To: Holden Karau Cc: Josef Sipek , hirofumi@mail.parknet.co.jp, linux-kernel@vger.kernel.org, Holden Karau , "akpm@osdl.org" , linux-fsdevel@vger.kernel.org, Nick Piggin , Matthew Wilcox Subject: Re: [PATCH 1/1] fat: improve sync performance by grouping writes revised again Message-ID: <20061101202400.GA6888@wohnheim.fh-wedel.de> References: <4548C8AE.2090603@pigscanfly.ca> <20061101164715.GC16154@wohnheim.fh-wedel.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1029 Lines: 28 On Wed, 1 November 2006 13:02:12 -0500, Holden Karau wrote: > On 11/1/06, J?rn Engel wrote: > > > >Result would be something like: > > c_bh = kmalloc(... > > err = -ENOMEM; > > if (!c_bh) > > goto error; > That wouldn't work so well since we always return err, I don't quite follow. If the branch is taken, err is -ENOMEM. If the branch is not taken, err is set to 0 with the next instruction. Both methods definitely work. Whether one is preferrable over the other is imo 90% taste and maybe 10% better code on some architecture. So just pick what you prefer. J?rn -- Unless something dramatically changes, by 2015 we'll be largely wondering what all the fuss surrounding Linux was really about. -- Rob Enderle - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/