Message-ID: <454908F9.80905@cfl.rr.com>
Date: Wed, 01 Nov 2006 15:52:09 -0500
From: Phillip Susi <psusi@cfl.rr.com>
User-Agent: Thunderbird 1.5.0.7 (Windows/20060909)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?J=F6rn_Engel?= <joern@wohnheim.fh-wedel.de>
CC: Holden Karau <holden@pigscanfly.ca>,
       Josef Sipek <jsipek@fsl.cs.sunysb.edu>, hirofumi@mail.parknet.co.jp,
       linux-kernel@vger.kernel.org, Holden Karau <holdenk@xandros.com>,
       "akpm@osdl.org" <akpm@osdl.org>, linux-fsdevel@vger.kernel.org,
       Nick Piggin <nickpiggin@yahoo.com.au>, Matthew.Wilcox@vax.1wt.eu
Illegal-Object: Syntax error in CC: address found on vger.kernel.org:
	CC:	Matthew Wilcox
			^-extraneous tokens in address
Illegal-Object: Syntax error in CC: address found on vger.kernel.org:
	CC:	Matthew Wilcox
			^-extraneous tokens in address
Subject: Re: [PATCH 1/1] fat: improve sync performance by grouping writes
 revised again
References: <4548C8AE.2090603@pigscanfly.ca> <20061101164715.GC16154@wohnheim.fh-wedel.de> <f46018bb0611011002h1b3b6e5fjdc6cc032a7503dbd@mail.gmail.com> <20061101202400.GA6888@wohnheim.fh-wedel.de>
In-Reply-To: <20061101202400.GA6888@wohnheim.fh-wedel.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1652
Lines: 38

I think this is getting into micro-optimization, which is usually bad. 
Also moving the assignment of err outside the body of the if only 
results in slightly faster code in the case where there is an error, 
since you can test and _maybe_ conditionally jump directly to the error: 
label if it is not very far away.  With the assignment in the body, the 
conditional jump must jump to the assignment followed by an 
unconditional jump to the label.

In other words, the only time this micro optimization will be of benefit 
is if you are erroring out most of the time rather than only under 
exceptional conditions, AND the error label isn't too far away for a 
conditional branch to reach.  In other words, just don't do it ;)

J?rn Engel wrote:
> On Wed, 1 November 2006 13:02:12 -0500, Holden Karau wrote:
>> On 11/1/06, J?rn Engel <joern@wohnheim.fh-wedel.de> wrote:
>>> Result would be something like:
>>>        c_bh = kmalloc(...
>>>        err = -ENOMEM;
>>>        if (!c_bh)
>>>                goto error;
>> That wouldn't work so well since we always return err,
> 
> I don't quite follow.  If the branch is taken, err is -ENOMEM.  If the
> branch is not taken, err is set to 0 with the next instruction.
> 
> Both methods definitely work.  Whether one is preferrable over the
> other is imo 90% taste and maybe 10% better code on some architecture.
> So just pick what you prefer.
> 
> J?rn
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/