Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210531043502.2702645-1-hsinyi@chromium.org> <20210531043502.2702645-3-hsinyi@chromium.org>
In-Reply-To: <20210531043502.2702645-3-hsinyi@chromium.org>
From:   Enric Balletbo Serra <eballetbo@gmail.com>
Date:   Mon, 31 May 2021 23:39:35 +0200
Message-ID: <CAFqH_53DWQVRVHVr8EVSR6A2oVqC4_4VjkE6n77g5kfBaa2+4A@mail.gmail.com>
Subject: Re: [PATCH 3/3] arm64: dts: mt8183: remove syscon from smi_common node
To:     Hsin-Yi Wang <hsinyi@chromium.org>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Linux ARM <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Rob Herring <robh+dt@kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        chun-jie.chen@mediatek.corp-partner.google.com,
        Yong Wu <yong.wu@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Hsin-Yi,

(again without html, sorry for the noise)

Thank you for the patch.

Missatge de Hsin-Yi Wang <hsinyi@chromium.org> del dia dl., 31 de maig
2021 a les 6:36:
>
> We don't need to register smi_common as syscon. Also add required
> property power-domains for this node.
>
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index c5e822b6b77a..e074c0d402ff 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -1263,13 +1263,14 @@ larb0: larb@14017000 {
>                 };
>
>                 smi_common: smi@14019000 {
> -                       compatible = "mediatek,mt8183-smi-common", "syscon";
> +                       compatible = "mediatek,mt8183-smi-common";
>                         reg = <0 0x14019000 0 0x1000>;
>                         clocks = <&mmsys CLK_MM_SMI_COMMON>,
>                                  <&mmsys CLK_MM_SMI_COMMON>,
>                                  <&mmsys CLK_MM_GALS_COMM0>,
>                                  <&mmsys CLK_MM_GALS_COMM1>;
>                         clock-names = "apb", "smi", "gals0", "gals1";
> +                       power-domains = <&spm MT8183_POWER_DOMAIN_DISP>;
>                 };
>
>                 imgsys: syscon@15020000 {
> --
> 2.32.0.rc0.204.g9fa02ecfa5-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek