Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 00:42:28 +0200
From:   Jiri Olsa <jolsa@redhat.com>
To:     Jin Yao <yao.jin@linux.intel.com>
Cc:     acme@kernel.org, jolsa@kernel.org, peterz@infradead.org,
        mingo@redhat.com, alexander.shishkin@linux.intel.com,
        Linux-kernel@vger.kernel.org, ak@linux.intel.com,
        kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2 6/8] perf mem: Fix wrong verbose output for recording
 events
Message-ID: <YLVmVBDKGkSWgHwR@krava>
References: <20210527001610.10553-1-yao.jin@linux.intel.com>
 <20210527001610.10553-7-yao.jin@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210527001610.10553-7-yao.jin@linux.intel.com>
Precedence: bulk

On Thu, May 27, 2021 at 08:16:08AM +0800, Jin Yao wrote:
> Current code:
> 
> for (j = 0; j < argc; j++, i++)
>         rec_argv[i] = argv[j];
> 
> if (verbose > 0) {
>         pr_debug("calling: record ");
> 
>         while (rec_argv[j]) {
>                 pr_debug("%s ", rec_argv[j]);
>                 j++;
>         }
>         pr_debug("\n");
> }
> 
> The entries of argv[] are copied to the end of rec_argv[], not
> copied to the beginning of rec_argv[]. So the index j at
> rec_argv[] doesn't point to the first event.
> 
> Now we record the start index and end index for events in rec_argv[],
> and print them if verbose is enabled.
> 
> Signed-off-by: Jin Yao <yao.jin@linux.intel.com>
> ---
> v2:
>  - New in v2.
> 
>  tools/perf/builtin-mem.c | 8 +++++---

hi,
do we need the same in c2c as well?

jirka

>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/builtin-mem.c b/tools/perf/builtin-mem.c
> index 6b633df458c2..0fd2a74dbaca 100644
> --- a/tools/perf/builtin-mem.c
> +++ b/tools/perf/builtin-mem.c
> @@ -65,6 +65,7 @@ static const char * const *record_mem_usage = __usage;
>  static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
>  {
>  	int rec_argc, i = 0, j, tmp_nr = 0;
> +	int start, end;
>  	const char **rec_argv;
>  	char **rec_tmp;
>  	int ret;
> @@ -144,9 +145,11 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
>  	if (mem->data_page_size)
>  		rec_argv[i++] = "--data-page-size";
>  
> +	start = i;
>  	ret = perf_mem_events__record_args(rec_argv, &i, rec_tmp, &tmp_nr);
>  	if (ret)
>  		goto out;
> +	end = i;
>  
>  	if (all_user)
>  		rec_argv[i++] = "--all-user";
> @@ -160,10 +163,9 @@ static int __cmd_record(int argc, const char **argv, struct perf_mem *mem)
>  	if (verbose > 0) {
>  		pr_debug("calling: record ");
>  
> -		while (rec_argv[j]) {
> +		for (j = start; j < end; j++)
>  			pr_debug("%s ", rec_argv[j]);
> -			j++;
> -		}
> +
>  		pr_debug("\n");
>  	}
>  
> -- 
> 2.17.1
>