Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Qiheng Lin <linqiheng@huawei.com>
Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared
 extern
To:     Borislav Petkov <bp@alien8.de>
CC:     <tglx@linutronix.de>, <mingo@redhat.com>, <x86@kernel.org>,
        <hpa@zytor.com>, <linux-kernel@vger.kernel.org>
References: <20210531031009.21737-1-linqiheng@huawei.com>
 <YLS8+gMRp62s4WEY@zn.tnic>
Message-ID: <b0a08543-1ec6-f559-a6d8-fb2d49fadb5d@huawei.com>
Date:   Tue, 1 Jun 2021 14:16:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.9.0
MIME-Version: 1.0
In-Reply-To: <YLS8+gMRp62s4WEY@zn.tnic>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2021/5/31 18:39, Borislav Petkov 写道:
>> Subject: Re: [PATCH -next] x86/kprobes: functions should not be declared extern
> 
> The condensed patch description in the subject line should start with a
> uppercase letter and should be written in imperative tone.
> 
> Also, the subject is wrong. Hint: "declaration" vs "definition".
> 
> On Mon, May 31, 2021 at 11:10:09AM +0800, Qiheng Lin wrote:
>> The function declaration in kprobes.h is already marked extern, thus its
>> definition should not have the keyword.
>>
>> This quiets the following sparse warning:
>>   function 'arch_unoptimize_kprobes' with external linkage has definition
> 
> This sounds like you're fixing something just because some tool
> complains and not because there's a real problem you're fixing.
> 
> Please rewrite your commit messages to state what the problem is and
> why you're fixing that problem. The tool output can be used to say
> something along the lines of "this problem was caught by this tool" but
> not as "see, tool X complains and creates a warning and I must fix that
> warning immediately."

Thank you for the review. I will send the v2.