Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3247794pxj; Tue, 1 Jun 2021 00:34:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbeE2a3AOKHimqvesSHd4NS2/qCJDDzjEth2UeiM5ZfcJxRwJDOBkLKsJxGlAxqPATsOfd X-Received: by 2002:a5d:804c:: with SMTP id b12mr10172524ior.15.1622532866786; Tue, 01 Jun 2021 00:34:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622532866; cv=none; d=google.com; s=arc-20160816; b=QumEJ8lSEcmOMEyUqc6Ey83Au23fhy37MM55+yRaVCdHD65jFqcfC+0lPe9m54OSoH RRxh12Bf8nDfX3xzJrGhdp7nmzTE1NEvF5Fj7v9EUrd6GnACiaRByl0tOL69pMJUqYj0 mvymXYWbI554KvlAkofbIeHMCH3QmauSV3O+gCYAbOVa248cyUf0X9n0Gn+AlhS94AqT +0npTU3Ko8jD+kx/gazsElwKvboYdFMoYtU6HvvllEBN+tdHllTr8nD4kQW0w+j8xMqj sTiV1ZszqZ+PZ4YSzUevuPrS3fsmc6V2y3Yy9pwGTcxjyy22Ixcj1PxcREWbW/tnQlhf BINw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=AgHWdwR+VI+grVUjUxxHl1DXyGVaeN8si6EvS4zm/rc=; b=jmb9qR32EcFgJeoAQekdOiQwOeMpRoM/Kux/9kBaPxjDpmZFdmozih/USF5BnMtM50 GDmIm0Kdbdo27acFsqSUAn094ClsG2O+Pl2joFoOAc4XPP704EgFDEDLZNQhbCAIwmfm n29lGLT4S++BV0pRiB/kW4Tgi59pvnHYkQ6dfKkSLO2oBMcFRGHp/roEdmiIZnc9bWnq HDw3AQ6SyYzsf5NKldriASTdmYGCMr7j/xt8oe46U4VrrNHFnjB4vgHrHZV1idxviiLf v7t8snsQ/4PrD/s24A7aMiFT2Z/KTVhBLAi4RIN4JSy9HbrckZUqz/ifvIWBepCi62Gb HQpw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b26si17042825jap.85.2021.06.01.00.34.14; Tue, 01 Jun 2021 00:34:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233165AbhFAHe5 (ORCPT + 99 others); Tue, 1 Jun 2021 03:34:57 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2813 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230326AbhFAHe5 (ORCPT ); Tue, 1 Jun 2021 03:34:57 -0400 Received: from dggeme760-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvP0J4bRLzWpsH; Tue, 1 Jun 2021 15:28:32 +0800 (CST) Received: from localhost.localdomain (10.175.104.82) by dggeme760-chm.china.huawei.com (10.3.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 1 Jun 2021 15:33:12 +0800 From: Zheng Yongjun To: , , , CC: , , Zheng Yongjun Subject: [PATCH net-next] iavf: Declare the function iavf_shutdown_adminq as void Date: Tue, 1 Jun 2021 15:46:50 +0800 Message-ID: <20210601074650.4078830-1-zhengyongjun3@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggeme760-chm.china.huawei.com (10.3.19.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org variable 'ret_code' is unneeded and it's noneed to check the return value of function iavf_shutdown_adminq,so declare it as void. Signed-off-by: Zheng Yongjun --- drivers/net/ethernet/intel/iavf/iavf_adminq.c | 6 +----- drivers/net/ethernet/intel/iavf/iavf_prototype.h | 2 +- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/intel/iavf/iavf_adminq.c b/drivers/net/ethernet/intel/iavf/iavf_adminq.c index 9fa3fa99b4c2..23612c15b111 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_adminq.c +++ b/drivers/net/ethernet/intel/iavf/iavf_adminq.c @@ -549,17 +549,13 @@ enum iavf_status iavf_init_adminq(struct iavf_hw *hw) * iavf_shutdown_adminq - shutdown routine for the Admin Queue * @hw: pointer to the hardware structure **/ -enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw) +void iavf_shutdown_adminq(struct iavf_hw *hw) { - enum iavf_status ret_code = 0; - if (iavf_check_asq_alive(hw)) iavf_aq_queue_shutdown(hw, true); iavf_shutdown_asq(hw); iavf_shutdown_arq(hw); - - return ret_code; } /** diff --git a/drivers/net/ethernet/intel/iavf/iavf_prototype.h b/drivers/net/ethernet/intel/iavf/iavf_prototype.h index edebfbbcffdc..29486aaad116 100644 --- a/drivers/net/ethernet/intel/iavf/iavf_prototype.h +++ b/drivers/net/ethernet/intel/iavf/iavf_prototype.h @@ -17,7 +17,7 @@ /* adminq functions */ enum iavf_status iavf_init_adminq(struct iavf_hw *hw); -enum iavf_status iavf_shutdown_adminq(struct iavf_hw *hw); +void iavf_shutdown_adminq(struct iavf_hw *hw); void iavf_adminq_init_ring_data(struct iavf_hw *hw); enum iavf_status iavf_clean_arq_element(struct iavf_hw *hw, struct iavf_arq_event_info *e, -- 2.25.1