Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3261577pxj; Tue, 1 Jun 2021 00:56:51 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzv5rlgSaDDhxzRQ5YOScjzzpBix+i+1/ExZLctyUR0zMz+OQ3v2RC31Y3I/i7CQ2a6EkWr X-Received: by 2002:a92:7510:: with SMTP id q16mr20307401ilc.291.1622534211138; Tue, 01 Jun 2021 00:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622534211; cv=none; d=google.com; s=arc-20160816; b=DhxEzKqHCzVV1oS7CSrTC8DBf7i3UVctyuMEn5Wzjes6Mc+/5cMI+boBcb2XeyYMPo eVYU36Q12OOt3kt2mfNp/C0+Far3HPa82ANRB9pMVZpzYVPUHlANDV1EZzXD93S4C+iX 4a7DmfuMwZpHwzl0MpAXQXg96436vIRCplquvzkh14n1PIxZf7SpqtPbNtMUz65z5Pc0 iGGE533mrpCX2OnlSVetl81Wg2rmY/aWlZ/DzydaPqydk4PTGhnuQOnSTUmOBF2/G/9U 9dAAefFnQ1ftY+wr2gISCcW82KQYqqlqzgzTkLs7MNp9bV/cWIQrT3qRQOMj8ZAJIKIV GywQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=0fDs9KSHH9PxlTS1XPn68l/OzUEcuff5ly812mW4exo=; b=zuUqBc68tYC9fHNdaNsVPXrSuKhChLmCyljl9zcE8GNLezf4jhxoy05njgt88UP9VA 8n7GZGKHSGY4IOVpRQ5eUuNnJ4wmJ5OzgWooX9TXLolyYvXFKiu1EvP4VCIMO/QQeM37 9Y4IeTr0SDDdNSsToif50pHlEbaZqEEC8ihvB1F8x6tXLjyVLH/Y3g03fLpBzaydamZF HlkBbQoQ3/pmtibvUeQUGtuU7oh+9XzqSLyCikUWAfWYtXWw90gsxqMfkvErYR8LCU4l EHlD9F1Xim46tDdcIx08pqyLcUT9AkKomNVJU3uPryCIox0Y7ibn8yknzjD7ARxNJdTt SrHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z1si16318444ilo.98.2021.06.01.00.56.38; Tue, 01 Jun 2021 00:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233083AbhFAH5s (ORCPT + 99 others); Tue, 1 Jun 2021 03:57:48 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:6106 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233056AbhFAH5r (ORCPT ); Tue, 1 Jun 2021 03:57:47 -0400 Received: from dggeme764-chm.china.huawei.com (unknown [172.30.72.57]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvPXw1fLxzYmXf; Tue, 1 Jun 2021 15:53:20 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by dggeme764-chm.china.huawei.com (10.3.19.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 1 Jun 2021 15:56:03 +0800 From: Jing Xiangfeng To: , , , CC: , , Subject: [PATCH] vdpa: fix error return in vp_vdpa_probe() Date: Tue, 1 Jun 2021 16:05:05 +0800 Message-ID: <20210601080505.8394-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggeme764-chm.china.huawei.com (10.3.19.110) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix to return error code '-ENOMEM' from the error handling case instead of 0. Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()") Signed-off-by: Jing Xiangfeng --- drivers/vdpa/virtio_pci/vp_vdpa.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c index c76ebb531212..e5d92db728d3 100644 --- a/drivers/vdpa/virtio_pci/vp_vdpa.c +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id) vp_modern_map_vq_notify(mdev, i, &vp_vdpa->vring[i].notify_pa); if (!vp_vdpa->vring[i].notify) { + ret = -ENOMEM; dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i); goto err; } -- 2.26.0.106.g9fadedd