Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 07:59:51 +0000
From:   Wei Liu <wei.liu@kernel.org>
To:     Nuno Das Neves <nunodasneves@linux.microsoft.com>
Cc:     linux-hyperv@vger.kernel.org, linux-kernel@vger.kernel.org,
        virtualization@lists.linux-foundation.org, mikelley@microsoft.com,
        viremana@linux.microsoft.com, sunilmut@microsoft.com,
        wei.liu@kernel.org, vkuznets@redhat.com, ligrassi@microsoft.com,
        kys@microsoft.com
Subject: Re: [PATCH 06/19] drivers/hv: create, initialize, finalize, delete
 partition hypercalls
Message-ID: <20210601075951.2ssgwaajo53x2tna@liuwe-devbox-debian-v2>
References: <1622241819-21155-1-git-send-email-nunodasneves@linux.microsoft.com>
 <1622241819-21155-7-git-send-email-nunodasneves@linux.microsoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1622241819-21155-7-git-send-email-nunodasneves@linux.microsoft.com>
Precedence: bulk

On Fri, May 28, 2021 at 03:43:26PM -0700, Nuno Das Neves wrote:
[...]
> diff --git a/arch/x86/include/uapi/asm/hyperv-tlfs.h b/arch/x86/include/uapi/asm/hyperv-tlfs.h
> index 72150c25ffe6..8a5fc59bb33a 100644
> --- a/arch/x86/include/uapi/asm/hyperv-tlfs.h
> +++ b/arch/x86/include/uapi/asm/hyperv-tlfs.h
> @@ -101,7 +101,7 @@ union hv_partition_processor_features {
>  		__u64 fsrep_stosb:1;
>  		__u64 fsrep_cmpsb:1;
>  		__u64 reserved_bank1:42;
> -	};
> +	} __packed;
>  	__u64 as_uint64[HV_PARTITION_PROCESSOR_FEATURE_BANKS];
>  };
>  
> @@ -111,7 +111,7 @@ union hv_partition_processor_xsave_features {
>  		__u64 xsaveopt_support : 1;
>  		__u64 avx_support : 1;
>  		__u64 reserved1 : 61;
> -	};
> +	} __packed;
>  	__u64 as_uint64;
>  };
>  
> @@ -119,6 +119,6 @@ struct hv_partition_creation_properties {
>  	union hv_partition_processor_features disabled_processor_features;
>  	union hv_partition_processor_xsave_features
>  		disabled_processor_xsave_features;
> -};
> +} __packed;

These hunks should have been squashed to the previous patch. They don't
belong here.

Wei.