Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] scsi: libsas: Use fallthrough pseudo-keyword
To:     Wei Ming Chen <jj251510319013@gmail.com>,
        <linux-kernel@vger.kernel.org>
CC:     <linux-scsi@vger.kernel.org>, <jejb@linux.ibm.com>,
        <martin.petersen@oracle.com>,
        "Gustavo A. R. Silva" <gustavo@embeddeodr.com>
References: <20210531153724.3149-1-jj251510319013@gmail.com>
From:   John Garry <john.garry@huawei.com>
Message-ID: <287b6910-17e8-9ef7-0042-9b525259967e@huawei.com>
Date:   Tue, 1 Jun 2021 09:16:49 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.2
MIME-Version: 1.0
In-Reply-To: <20210531153724.3149-1-jj251510319013@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

+ Gustavo

On 31/05/2021 16:37, Wei Ming Chen wrote:
> Replace /* Fall through */ comment with pseudo-keyword macro fallthrough[1]
> 
> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html?highlight=fallthrough#implicit-switch-case-fall-through
> 
> Signed-off-by: Wei Ming Chen <jj251510319013@gmail.com>
> ---
>   drivers/scsi/libsas/sas_discover.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/libsas/sas_discover.c b/drivers/scsi/libsas/sas_discover.c
> index 9f5068f3bcfb..dd205414e505 100644
> --- a/drivers/scsi/libsas/sas_discover.c
> +++ b/drivers/scsi/libsas/sas_discover.c
> @@ -461,7 +461,7 @@ static void sas_discover_domain(struct work_struct *work)
>   		break;
>   #else
>   		pr_notice("ATA device seen but CONFIG_SCSI_SAS_ATA=N so cannot attach\n");
> -		/* Fall through */
> +		fallthrough;

I don't know why we need the 2nd fall through (and the compiler can't 
see the first one) - added by Gustavo in da1fb2909 - but I think that 
this one can now simply be removed.

>   #endif
>   		/* Fall through - only for the #else condition above. */
Thanks,
John

>   	default:
>