Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752301AbWKBABy (ORCPT ); Wed, 1 Nov 2006 19:01:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752308AbWKBABy (ORCPT ); Wed, 1 Nov 2006 19:01:54 -0500 Received: from ozlabs.org ([203.10.76.45]:57504 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1752297AbWKBABx (ORCPT ); Wed, 1 Nov 2006 19:01:53 -0500 Subject: Re: [PATCH 4/7] paravirtualization: Allow selected bug checks to be skipped by paravirt kernels From: Rusty Russell To: Andrew Morton Cc: Andi Kleen , Andi Kleen , virtualization@lists.osdl.org, Chris Wright , linux-kernel@vger.kernel.org In-Reply-To: <20061101152946.14f95f79.akpm@osdl.org> References: <20061029024504.760769000@sous-sol.org> <20061029024607.401333000@sous-sol.org> <200610290831.21062.ak@suse.de> <1162178936.9802.34.camel@localhost.localdomain> <20061030231132.GA98768@muc.de> <1162376827.23462.5.camel@localhost.localdomain> <1162376894.23462.7.camel@localhost.localdomain> <1162376981.23462.10.camel@localhost.localdomain> <1162377043.23462.12.camel@localhost.localdomain> <20061101152946.14f95f79.akpm@osdl.org> Content-Type: text/plain Date: Thu, 02 Nov 2006 11:01:50 +1100 Message-Id: <1162425710.6848.9.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1123 Lines: 38 On Wed, 2006-11-01 at 15:29 -0800, Andrew Morton wrote: > On Wed, 01 Nov 2006 21:30:43 +1100 > Rusty Russell wrote: > > > --- a/include/asm-i386/bugs.h > > +++ b/include/asm-i386/bugs.h > > @@ -21,6 +21,7 @@ > > #include > > #include > > #include > > +#include > > In many other places you have > > #ifdef CONFIG_PARAVIRT > #include > ... > > But not here. > > Making invulnerable would be the more typical approach. It *is* actually safe. The "#ifdef CONFIG_PARAVIRT / #include / #else / <... native versions...>" is to give a big hint to the reader to look in paravirt.h for the real definitions. Originally I had a noparavirt.h where all these lived, and people hated it. So we did it this way, which minimizes churn. Rusty. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/