Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 10:09:07 +0100
From:   Lee Jones <lee.jones@linaro.org>
To:     Moriis Ku <saumah@gmail.com>
Cc:     linux-kernel@vger.kernel.org, jason_lee@sunix.com,
        taian.chen@sunix.com
Subject: Re: [PATCH] mfd:Add supprt for SUNIX mfd & PCIe driver
Message-ID: <20210601090907.GA543307@dell>
References: <20210528095814.6939-1-saumah@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210528095814.6939-1-saumah@gmail.com>
Precedence: bulk

On Fri, 28 May 2021, Moriis Ku wrote:

> From: Morris Ku <saumah@gmail.com>
> 
> Add support for SUNIX mfd & PCIe driver

That's a pretty broad description.


> Cc: Jason Lee <jason_lee@sunix.com>
> Cc: Taian Chen <taian.chen@sunix.com>
> Signed-off-by: Morris Ku <saumah@gmail.com>
> ---
>  Kconfig  | 12 ++++++++++++
>  Makefile |  4 ++++
>  2 files changed, 16 insertions(+)

Patches should be generated from the root of the source directory.

> diff --git a/Kconfig b/Kconfig
> index 17d0ad2..25b7db5 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -2012,6 +2012,18 @@ config RAVE_SP_CORE
>  	  Select this to get support for the Supervisory Processor
>  	  device found on several devices in RAVE line of hardware.
>  
> +config MFD_SUNIX_SDC
> +	tristate
> +	select MFD_CORE
> +	select SERIAL_8250_SDC
> +
> +config MFD_SUNIX_SDC_PCI
> +	tristate "SUNIX SDC PCIe multi-function board support"

What is SDC?

> +	select MFD_SUNIX_SDC
> +	depends on X86 && PCI
> +	help
> +	  Selecting this option will add support for SUNIX SDC PCIe
> +	  multi-function board.

More please.

>  endmenu
>  endif
> diff --git a/Makefile b/Makefile
> index a1872e4..52fa8be 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -256,4 +256,8 @@ obj-$(CONFIG_MFD_ROHM_BD70528)	+= rohm-bd70528.o
>  obj-$(CONFIG_MFD_ROHM_BD718XX)	+= rohm-bd718x7.o
>  obj-$(CONFIG_MFD_STMFX) 	+= stmfx.o
>  
> +obj-$(CONFIG_MFD_SUNIX_SDC)		+= sdc_mfd.o

There is no such thing as MFD.

You probably mean 'core'.

> +obj-$(CONFIG_MFD_SUNIX_SDC_PCI)	+= sdc_pci.o
> +
> +

No need for 2 empty spaces.

This patch doesn't actually do anything.

Please submit it squashed into the driver.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog