Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 11:16:17 +0200
From:   Mauro Carvalho Chehab <mchehab@kernel.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] media: av7110_v4l: Fix build error
Message-ID: <20210601111617.5856e175@coco.lan>
In-Reply-To: <20200909133844.6812-1-yuehaibing@huawei.com>
References: <20200909133844.6812-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Em Wed, 9 Sep 2020 21:38:44 +0800
YueHaibing <yuehaibing@huawei.com> escreveu:

> drivers/media/pci/ttpci/av7110_v4l.c: In function =E2=80=98vidioc_s_frequ=
ency=E2=80=99:
> drivers/media/pci/ttpci/av7110_v4l.c:163:11: error: SSE register return w=
ith SSE disabled
>   if (freq < 16U * 168.25)
>       ~~~~~^~~~~~~~~~~~~~
> Get rid of float pointing math to fix this.

Out of curiosity: what compiler are you using? This sounds to be a compiler
issue, as compiler should be optimizing the code by doing the math evaluati=
on
at compile time instead of doing it during runtime.

>=20
> Fixes: 13c129066845 ("media: av7110_v4l: avoid a typecast")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/media/pci/ttpci/av7110_v4l.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/media/pci/ttpci/av7110_v4l.c b/drivers/media/pci/ttp=
ci/av7110_v4l.c
> index 6d9c908be713..ba745b161cba 100644
> --- a/drivers/media/pci/ttpci/av7110_v4l.c
> +++ b/drivers/media/pci/ttpci/av7110_v4l.c
> @@ -160,9 +160,9 @@ static int ves1820_set_tv_freq(struct saa7146_dev *de=
v, u32 freq)
>  	buf[1] =3D div & 0xff;
>  	buf[2] =3D 0x8e;
> =20
> -	if (freq < 16U * 168.25)
> +	if (freq < (16 * 16825) / 100)
>  		config =3D 0xa0;
> -	else if (freq < 16U * 447.25)
> +	else if (freq < (16 * 44725) / 100)
>  		config =3D 0x90;
>  	else
>  		config =3D 0x30;


Thanks,
Mauro