Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 11:29:50 +0200
From:   Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To:     Ruiqi Gong <gongruiqi1@huawei.com>
Cc:     Wang Weiyang <wangweiyang2@huawei.com>, linux-mips@vger.kernel.org,
        kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] MIPS: pm-cps: Make '__pcpu_scope_cps_cpu_state'
 static
Message-ID: <20210601092949.GA6961@alpha.franken.de>
References: <20210528070437.5780-1-gongruiqi1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210528070437.5780-1-gongruiqi1@huawei.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk

On Fri, May 28, 2021 at 03:04:37PM +0800, Ruiqi Gong wrote:
> Mark the per-CPU definition of cps_cpu_state as static to fix the following
> sparse tool complain:
> 
> arch/mips/kernel/pm-cps.c:66:1: warning:
>  symbol '__pcpu_scope_cps_cpu_state' was not declared. Should it be static?

did you compile/link a kernel with this patch ? I doubt that since there
is a refernec to this symbol in arch/mips/kernel/cps-vec.S.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]