Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3334013pxj; Tue, 1 Jun 2021 02:55:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz32K3K/mncOmJatarzCkMRTc7KVthPApJqBnpT3DDre3eEQ3C5qTLG6TbAaHkqicp7XEW6 X-Received: by 2002:a6b:b48a:: with SMTP id d132mr20866820iof.167.1622541341847; Tue, 01 Jun 2021 02:55:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622541341; cv=none; d=google.com; s=arc-20160816; b=BKtLMWtcpIzuyUBhqXL/v4/KItvBMNf9sEeES00RbWxYLPGp0vWz3lo7KPvn+PVK6t IsX4WPEASXq2QkSXJi36Ztzyh0ehR1/V0KLuiBSlTI1n7PoEUm/QH1DxfUGFo693XkSO GA5U++4vY5aZjUu4bLC/FT2g4MsYqTPRiMfpcjvv9TZa8uiBuh90iaQWOIJfFgqrQEuL EAmahF5HdE33hGR6jfSmjGMDKWIg+bVVBFQ3ii1g3zZo0lcpVBqjoKERc/kkNR5wvEWl KyUgt0TIX0AB/uDeULseWoGK+Vf1Hn094MO6F9DXTrf4NQP9VT+0mxRMf+8q2tiB/T9B NuLQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=hlo22pYvotDtvckqCXNXK5Nc5Pvp6gWxbkPsLOPZmxU=; b=drSfH8ZJj3DKFo2Ts5s9y+8uBEuITRjEeOwzmfpfG08/kF6WToGp57YCSXQ7fcHaUl k5gzC+aaU1N11eydNMN6rzs+jJzIOOgY9QpM+jJ9FUEhSaTNuZAx9O15h8YSJNnu0whf TpHLwI4/H2N9uuOPYY/B6tfztI56S6jGSBeeQaKUaQSMhJvkSIRp7OLBbKgsD3rqJCKk G1JxjsdqOr/s+ikCnDlpIOyxMrI0Ydlrd0xsG3vqGPU02CXygvB76n/YZw1itzEb6dlQ xiauewSr10hgMfAJCUrAOM41F6gY9DITbm4ySkclBdoKvAUIcUt1Xr6Zbfi894RC1Nrv qanQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i1si1267093ilv.76.2021.06.01.02.55.29; Tue, 01 Jun 2021 02:55:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231971AbhFAJzh (ORCPT + 99 others); Tue, 1 Jun 2021 05:55:37 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:2821 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbhFAJze (ORCPT ); Tue, 1 Jun 2021 05:55:34 -0400 Received: from dggemv711-chm.china.huawei.com (unknown [172.30.72.54]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4FvS6Z2K3dzWnXr; Tue, 1 Jun 2021 17:49:10 +0800 (CST) Received: from dggpemm000001.china.huawei.com (7.185.36.245) by dggemv711-chm.china.huawei.com (10.1.198.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 1 Jun 2021 17:53:51 +0800 Received: from localhost.localdomain.localdomain (10.175.113.25) by dggpemm000001.china.huawei.com (7.185.36.245) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 1 Jun 2021 17:53:51 +0800 From: Tong Tiangen To: Greg Kroah-Hartman CC: , , Tong Tiangen Subject: [PATCH -next] usb: isp1760: Fix meaningless check in isp1763_run() Date: Tue, 1 Jun 2021 18:03:11 +0800 Message-ID: <20210601100311.70200-1-tongtiangen@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To dggpemm000001.china.huawei.com (7.185.36.245) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There's a meaningless check in isp1763_run. According to the similar implement in isp1760_run, the proper check should remove retval = 0; Fixes: 60d789f3bfbb ("usb: isp1760: add support for isp1763") Signed-off-by: Tong Tiangen --- drivers/usb/isp1760/isp1760-hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/usb/isp1760/isp1760-hcd.c b/drivers/usb/isp1760/isp1760-hcd.c index 016a54ea76f4..27168b4a4ef2 100644 --- a/drivers/usb/isp1760/isp1760-hcd.c +++ b/drivers/usb/isp1760/isp1760-hcd.c @@ -1648,7 +1648,6 @@ static int isp1763_run(struct usb_hcd *hcd) down_write(&ehci_cf_port_reset_rwsem); retval = isp1760_hcd_set_and_wait(hcd, FLAG_CF, 250 * 1000); up_write(&ehci_cf_port_reset_rwsem); - retval = 0; if (retval) return retval; -- 2.18.0.huawei.25