Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20200914150958.2200-1-oli.swede@arm.com> <20200914150958.2200-9-oli.swede@arm.com>
In-Reply-To: <20200914150958.2200-9-oli.swede@arm.com>
From:   Sunil Kovvuri <sunil.kovvuri@gmail.com>
Date:   Tue, 1 Jun 2021 15:33:58 +0530
Message-ID: <CA+sq2CfGu+JPJ9h3Q-nCdmM2erqWbe=p-v_eip-J-R6F2EoXbw@mail.gmail.com>
Subject: Re: [PATCH v5 08/14] arm64: Import latest optimization of memcpy
To:     Oliver Swede <oli.swede@arm.com>
Cc:     Catalin Marinas <catalin.marinas@arm.com>, will@kernel.org,
        Robin Murphy <robin.murphy@arm.com>,
        linux-arm-kernel@lists.indradead.org,
        LKML <linux-kernel@vger.kernel.org>,
        Sunil Goutham <sgoutham@marvell.com>,
        George Cherian <gcherian@marvell.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Sep 14, 2020 at 8:44 PM Oliver Swede <oli.swede@arm.com> wrote:
>
> From: Sam Tebbs <sam.tebbs@arm.com>
>
> Import the latest memcpy implementation into memcpy,
> copy_{from, to and in}_user.
> The implementation of the user routines is separated into two forms:
> one for when UAO is enabled and one for when UAO is disabled, with
> the two being chosen between with a runtime patch.
> This avoids executing the many NOPs emitted when UAO is disabled.
>
> The project containing optimized implementations for various library
> functions has now been renamed from 'cortex-strings' to
> 'optimized-routines', and the new upstream source is
> string/aarch64/memcpy.S as of commit 4c175c8be12 in
> https://github.com/ARM-software/optimized-routines.
>
> Signed-off-by: Sam Tebbs <sam.tebbs@arm.com>
> [ rm: add UAO fixups, streamline copy_exit paths, expand commit message ]
> Signed-off-by: Robin Murphy <robin.murphy@arm.com>
> [ os: import newer memcpy algorithm, update commit message ]
> Signed-off-by: Oliver Swede <oli.swede@arm.com>
> ---
>  arch/arm64/include/asm/alternative.h |  36 ---
>  arch/arm64/lib/copy_from_user.S      | 113 ++++++--
>  arch/arm64/lib/copy_in_user.S        | 129 +++++++--
>  arch/arm64/lib/copy_template.S       | 375 +++++++++++++++------------
>  arch/arm64/lib/copy_template_user.S  |  24 ++
>  arch/arm64/lib/copy_to_user.S        | 112 ++++++--
>  arch/arm64/lib/copy_user_fixup.S     |  14 +
>  arch/arm64/lib/memcpy.S              |  47 ++--
>  8 files changed, 557 insertions(+), 293 deletions(-)
>  create mode 100644 arch/arm64/lib/copy_template_user.S
>  create mode 100644 arch/arm64/lib/copy_user_fixup.S

Do you have any performance data with this patch ?
I see these patches are still not pushed to mainline, any reasons ?

Also curious to know why 128bit registers are not considered, similar to
https://android.googlesource.com/platform/bionic.git/+/a71b4c3f144a516826e8ac5b262099b920c49ce0/libc/arch-arm64/generic-neon/bionic/memcpy.S

Thanks,
Sunil.