Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3343318pxj; Tue, 1 Jun 2021 03:09:40 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyNFZ3wTrEASMYxwx/lo/3t2BLChddQHD5yG0zZ5ngmYZlowqn3CFQplHEgU8rP7ylABU2A X-Received: by 2002:a17:906:51c7:: with SMTP id v7mr28965089ejk.86.1622542179927; Tue, 01 Jun 2021 03:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622542179; cv=none; d=google.com; s=arc-20160816; b=JkmxUd30mqVZG/wYrGE5Y7HbJEayBouq/HxARBGPraw2n9KXKHuEbZFlAMteGipeRW 6ulHB4IUE9Z8Vwri15KmsIZQ1ktzondwWk/YxeRvbtvy8PLtFI2n8qUOIsU88DRPkkay wjjKERGKDASr4bUjSLXG4Ancb1X2HD9n1kDM+xY1rJYkffF9fyPe50B0t5qJMDihi1zA U5R36lGR5MIIH9B/xyFeTMFnR0JqFzAyuncBqmIbjx9MZwh5qWrJqmCAAOBRkmIWLqrV kvFI7Ddq5RI9Opg87Vi59/9TTshGi+0P2KUVa3xtpWcAQzg0aqvQPyXSLR1NWEln2UQa 6yqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=uYSLokhZOVToHjDX8YvfZ/GTnhI3Vsb7W4Dw5LRfxX4=; b=mDKMkNyYT83QajThGnSheycbcf5hoE+s9jpEx0CsofAurg0VlT34TyZmEIuNu5evgi 7TNgIyWKOI/YcrWJ4MHXWGD0236VxilmHMIc20ZyzBC6OUeFzsMLaJcLzcfIQhIpwnAy 0ox1LCwvgbk76/JvVjGH1xIX+p+FhaGNMH7Lw4/Av4b2PEJNUw6+s0vV1NOtFuWx8OMA CR8LDMWsywrvdV3Jpg4sQG+HiLhkFYB56ZkdW/sPNuu6XjngPfTf1ahhkMhLCZKcuOl/ 0QPNUc+b3kIZOTQQpdntsrFJ2E8Y9+uB4Vgu0X244+2QrqdbcpARqBUcYKgqgrlvtdMv GcQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tYuVyBl2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id g12si8265894ejd.330.2021.06.01.03.09.15; Tue, 01 Jun 2021 03:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tYuVyBl2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230262AbhFAKH7 (ORCPT + 99 others); Tue, 1 Jun 2021 06:07:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbhFAKH7 (ORCPT ); Tue, 1 Jun 2021 06:07:59 -0400 Received: from mail-lj1-x230.google.com (mail-lj1-x230.google.com [IPv6:2a00:1450:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2FA1C061574 for ; Tue, 1 Jun 2021 03:06:17 -0700 (PDT) Received: by mail-lj1-x230.google.com with SMTP id e11so18380358ljn.13 for ; Tue, 01 Jun 2021 03:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uYSLokhZOVToHjDX8YvfZ/GTnhI3Vsb7W4Dw5LRfxX4=; b=tYuVyBl2SRvpemlHslfjIJuF62dTsodKJWlDgxntpqhM/T/7Uh2PzC2irWjNsXNC50 hf/wxmwRjEt1r40E1Ie/Mqd+eEilnkB0LFj6nUn3ZwXTqjuh8M4RtgFn39lUBPlFwTfQ kcsrYTg1x8BFQj6Gb7ZmkI+7NNmKw2ywQF8t1BLOSyKQpPosQaefBQsvta8I4Rpwed08 rhc8SjcSuWleV0RSdXwCkmU0BqsBT/V8rMtxLOZFWpAL7kksN/wdEprzSauYDYD6O7BH XsTm0qd9GJ49tm5z4Fh8r5EkPcVUFRSFhSJiZ7RWAEUQyb2ijbxN1LVM6cgNqkiNixK/ xlQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uYSLokhZOVToHjDX8YvfZ/GTnhI3Vsb7W4Dw5LRfxX4=; b=hvTq+Av7zj/TPRFxJ7Tmv4TqtjUNS5Vm7R/GI3apy8tI2CinjynC+EspDsFvYs+y4S GEFEcTVvSEgwCpKsxW2jgLhrjQ8HIjDXs1QMwdYz1Q9Un9kC2Tg4cgFh2AKG7HKvH+7g vSYib8xGmHnZTxmWvg0oXEeTbKtdGHCTFGzXiJDo+ZB0tr42jLgjqqbPUltzDIbLa/ru VEJWs5egbsRT5PpbbhuI/lJjR90PRJq/tsQTgLc5Ff52dnh8zyC4BFDgCmlY3bEEr3ju Fo1LJPhR/lMgEI6Iuxkmryo5CbOAOwMBOc4p1VjJLnU0F4RIJ+g4uMwfqWGjolvOjsJZ gDCg== X-Gm-Message-State: AOAM531rnC/SEL0E5cy271Yy8ypxBYQV2scIqAMEQj7Aqb24Q1kuE3wy WQbm6cEEk7lTf1NhJz1a+TTA/p1uDTP39tGDyXunAg== X-Received: by 2002:a2e:22c3:: with SMTP id i186mr20730123lji.273.1622541976021; Tue, 01 Jun 2021 03:06:16 -0700 (PDT) MIME-Version: 1.0 References: <20210529111935.3849707-1-andy.shevchenko@gmail.com> <20210529111935.3849707-12-andy.shevchenko@gmail.com> In-Reply-To: <20210529111935.3849707-12-andy.shevchenko@gmail.com> From: Linus Walleij Date: Tue, 1 Jun 2021 12:06:05 +0200 Message-ID: Subject: Re: [PATCH v2 12/13] leds: rt8515: Put fwnode in any case during ->probe() To: Andy Shevchenko Cc: Pavel Machek , Amireddy Mallikarjuna reddy , Abanoub Sameh , =?UTF-8?B?TWFyZWsgQmVow7pu?= , Krzysztof Kozlowski , Linux LED Subsystem , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 29, 2021 at 1:19 PM Andy Shevchenko wrote: > fwnode_get_next_available_child_node() bumps a reference counting of > a returned variable. We have to balance it whenever we return to > the caller. > > Fixes: e1c6edcbea13 ("leds: rt8515: Add Richtek RT8515 LED driver") > Cc: Linus Walleij > Signed-off-by: Andy Shevchenko Reviewed-by: Linus Walleij Yours, Linus Walleij