Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751417AbWKBAq0 (ORCPT ); Wed, 1 Nov 2006 19:46:26 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751420AbWKBAq0 (ORCPT ); Wed, 1 Nov 2006 19:46:26 -0500 Received: from ozlabs.org ([203.10.76.45]:6577 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S1751417AbWKBAq0 (ORCPT ); Wed, 1 Nov 2006 19:46:26 -0500 Subject: Re: [PATCH 6/7] paravirtualization: Add APIC accessors to paravirt-ops. From: Rusty Russell To: Andrew Morton Cc: Andi Kleen , Andi Kleen , virtualization@lists.osdl.org, Chris Wright , linux-kernel@vger.kernel.org In-Reply-To: <20061101153102.a192f6c9.akpm@osdl.org> References: <20061029024504.760769000@sous-sol.org> <20061029024607.401333000@sous-sol.org> <200610290831.21062.ak@suse.de> <1162178936.9802.34.camel@localhost.localdomain> <20061030231132.GA98768@muc.de> <1162376827.23462.5.camel@localhost.localdomain> <1162376894.23462.7.camel@localhost.localdomain> <1162376981.23462.10.camel@localhost.localdomain> <1162377043.23462.12.camel@localhost.localdomain> <1162377093.23462.14.camel@localhost.localdomain> <1162377150.23462.16.camel@localhost.localdomain> <20061101153102.a192f6c9.akpm@osdl.org> Content-Type: text/plain Date: Thu, 02 Nov 2006 11:46:23 +1100 Message-Id: <1162428383.6848.11.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.8.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1552 Lines: 45 On Wed, 2006-11-01 at 15:31 -0800, Andrew Morton wrote: > On Wed, 01 Nov 2006 21:32:30 +1100 > Rusty Russell wrote: > > > +static __inline void apic_write(unsigned long reg, unsigned long v) > > +static __inline void apic_write_atomic(unsigned long reg, unsigned long v) > > +static __inline unsigned long apic_read(unsigned long reg) > > Just `inline', please. akpm says: "Just `inline', please." Signed-off-by: Rusty Russell diff -r 3a3bc9aed04c include/asm-i386/paravirt.h --- a/include/asm-i386/paravirt.h Thu Nov 02 11:42:22 2006 +1100 +++ b/include/asm-i386/paravirt.h Thu Nov 02 11:44:15 2006 +1100 @@ -304,17 +304,17 @@ static inline void slow_down_io(void) { /* * Basic functions accessing APICs. */ -static __inline void apic_write(unsigned long reg, unsigned long v) +static inline void apic_write(unsigned long reg, unsigned long v) { paravirt_ops.apic_write(reg,v); } -static __inline void apic_write_atomic(unsigned long reg, unsigned long v) +static inline void apic_write_atomic(unsigned long reg, unsigned long v) { paravirt_ops.apic_write_atomic(reg,v); } -static __inline unsigned long apic_read(unsigned long reg) +static inline unsigned long apic_read(unsigned long reg) { return paravirt_ops.apic_read(reg); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/