Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates
 216.228.112.34 as permitted sender) receiver=protection.outlook.com;
 client-ip=216.228.112.34; helo=mail.nvidia.com;
Date:   Tue, 1 Jun 2021 13:28:40 +0300
From:   Eli Cohen <elic@nvidia.com>
To:     Jing Xiangfeng <jingxiangfeng@huawei.com>
CC:     <mst@redhat.com>, <jasowang@redhat.com>, <sgarzare@redhat.com>,
        <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vdpa: fix error return in vp_vdpa_probe()
Message-ID: <20210601102840.GC215954@mtl-vdi-166.wap.labs.mlnx>
References: <20210601080505.8394-1-jingxiangfeng@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20210601080505.8394-1-jingxiangfeng@huawei.com>
User-Agent: Mutt/1.9.5 (bf161cf53efb) (2018-04-13)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2021 10:28:46.3643
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 05f9ecdb-8c94-4ef8-45b4-08d924e809c7
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.112.34];Helo=[mail.nvidia.com]
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT036.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4813
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 01, 2021 at 04:05:05PM +0800, Jing Xiangfeng wrote:
> Fix to return error code '-ENOMEM' from the error handling case instead
> of 0.
> 
> Fixes: 11d8ffed00b2 ("vp_vdpa: switch to use vp_modern_map_vq_notify()")
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>

Reviewed-by: Eli Cohen <elic@nvidia.com>

> ---
>  drivers/vdpa/virtio_pci/vp_vdpa.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/vdpa/virtio_pci/vp_vdpa.c b/drivers/vdpa/virtio_pci/vp_vdpa.c
> index c76ebb531212..e5d92db728d3 100644
> --- a/drivers/vdpa/virtio_pci/vp_vdpa.c
> +++ b/drivers/vdpa/virtio_pci/vp_vdpa.c
> @@ -442,6 +442,7 @@ static int vp_vdpa_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  			vp_modern_map_vq_notify(mdev, i,
>  						&vp_vdpa->vring[i].notify_pa);
>  		if (!vp_vdpa->vring[i].notify) {
> +			ret = -ENOMEM;
>  			dev_warn(&pdev->dev, "Fail to map vq notify %d\n", i);
>  			goto err;
>  		}
> -- 
> 2.26.0.106.g9fadedd
>