Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 13:43:37 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Mel Gorman <mgorman@suse.de>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Yang Shi <shy828301@gmail.com>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] mm: thp: fix a double unlock bug
Message-ID: <20210601104337.GX1955@kadam>
References: <YLX8uYN01JmfLnlK@mwanda>
 <20210601100849.GQ3672@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601100849.GQ3672@suse.de>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Tue, Jun 01, 2021 at 11:08:49AM +0100, Mel Gorman wrote:
> On Tue, Jun 01, 2021 at 12:24:09PM +0300, Dan Carpenter wrote:
> > We're supposed to be holding the "vmf->ptl" spin_lock when we goto
> > out_map.  The lock is dropped after if finishes cleaning up.
> > 
> > Fixes: 9aff7b33c74a ("mm: thp: refactor NUMA fault handling")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Ouch.
> 
> Acked-by: Mel Gorman <mgorman@suse.de>
> 
> However, that git commit is not stable. Instead of Fixes: I would
> suggest renaming the patch to "mm: thp: refactor NUMA fault handling
> -fix" and replacing Fixes with "This patch is a fix to the mmotm patch
> mm-thp-refactor-numa-fault-handling.patch". Andrew usually slots that
> into the correct place in his quilt series and collapses the fixes before
> sending to Linus which works better with bisection.

I know that these normally get folded in, but I assumed that Andrew
would want the Fixes tag so that he could fold them in automatically
using a mutt alias. #OneClickShopping

regards,
dan carpenter