Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbWKBAyE (ORCPT ); Wed, 1 Nov 2006 19:54:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752375AbWKBAyE (ORCPT ); Wed, 1 Nov 2006 19:54:04 -0500 Received: from mailout1.vmware.com ([65.113.40.130]:58828 "EHLO mailout1.vmware.com") by vger.kernel.org with ESMTP id S1752324AbWKBAyC (ORCPT ); Wed, 1 Nov 2006 19:54:02 -0500 Message-ID: <454941A8.6000601@vmware.com> Date: Wed, 01 Nov 2006 16:54:00 -0800 From: Zachary Amsden User-Agent: Thunderbird 1.5.0.7 (X11/20060909) MIME-Version: 1.0 To: Rusty Russell Cc: Andrew Morton , Andi Kleen , Andi Kleen , virtualization@lists.osdl.org, Chris Wright , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] paravirtualization: Patch inline replacements for common paravirt operations. References: <20061029024504.760769000@sous-sol.org> <20061029024607.401333000@sous-sol.org> <200610290831.21062.ak@suse.de> <1162178936.9802.34.camel@localhost.localdomain> <20061030231132.GA98768@muc.de> <1162376827.23462.5.camel@localhost.localdomain> <1162376894.23462.7.camel@localhost.localdomain> <20061101152715.f1f94d5c.akpm@osdl.org> <1162428424.6848.14.camel@localhost.localdomain> In-Reply-To: <1162428424.6848.14.camel@localhost.localdomain> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 27 Rusty Russell wrote: > On Wed, 2006-11-01 at 15:27 -0800, Andrew Morton wrote: > >> On Wed, 01 Nov 2006 21:28:13 +1100 >> Rusty Russell wrote: >> >>> +#ifdef CONFIG_DEBUG_KERNEL >>> + /* Deliberately clobber regs using "not %reg" to find bugs. */ >>> >> That would be considered to be abusive of CONFIG_DEBUG_KERNEL. A >> CONFIG_DEBUG_PARAVIRT which depends on CONFIG_DEBUG_KERNEL would be more >> harmonious. >> > > I wasn't sure. Making a config option for what is a one-liner seemed > overkill. > I have further stuff in my vmi-debug patch that can use CONFIG_DEBUG_PARAVIRT as well :) Zach - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/