Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date:   Tue, 01 Jun 2021 12:03:59 +0100
Message-Id: <CBS8CSIHJTXJ.1HWQ3AWYCC1V8@arch-thunder>
Cc:     <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] media: imx: imx7_mipi_csis: convert some switch cases
 to the default
From:   "Rui Miguel Silva" <rmfrfs@gmail.com>
To:     <trix@redhat.com>, <laurent.pinchart@ideasonboard.com>,
        <slongerbeam@gmail.com>, <p.zabel@pengutronix.de>,
        <mchehab@kernel.org>, <gregkh@linuxfoundation.org>,
        <shawnguo@kernel.org>, <s.hauer@pengutronix.de>,
        <kernel@pengutronix.de>, <festevam@gmail.com>, <linux-imx@nxp.com>
References: <20210531174300.2594109-1-trix@redhat.com>
In-Reply-To: <20210531174300.2594109-1-trix@redhat.com>
Precedence: bulk

Hi Tom,
Thanks for the patch.

On Mon May 31, 2021 at 6:43 PM WEST,  wrote:

> From: Tom Rix <trix@redhat.com>
>
> Static analysis reports this false positive
> imx7-mipi-csis.c:1027:2: warning: 4th function call argument is
>   an uninitialized value
>
> The variable 'align' is falsely reported as uninitialized.
> Even though all the cases are covered in the
> 	switch (csis_fmt->width % 8) {
>
> Because there is no default case, it is reported as uninialized.
>
> Improve the switch by converting the most numerous set of cases
> to the default and silence the false positive.
>
> Signed-off-by: Tom Rix <trix@redhat.com>

It solves that, looks good to me.

Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com>

------
Cheers,
     Rui

> ---
>  drivers/staging/media/imx/imx7-mipi-csis.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging=
/media/imx/imx7-mipi-csis.c
> index d573f3475d28..330f283030ec 100644
> --- a/drivers/staging/media/imx/imx7-mipi-csis.c
> +++ b/drivers/staging/media/imx/imx7-mipi-csis.c
> @@ -1016,10 +1016,8 @@ static int mipi_csis_set_fmt(struct v4l2_subdev *s=
d,
>  	case 6:
>  		align =3D 2;
>  		break;
> -	case 1:
> -	case 3:
> -	case 5:
> -	case 7:
> +	default:
> +		/* 1, 3, 5, 7 */
>  		align =3D 3;
>  		break;
>  	}
> --=20
> 2.26.3