Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3381503pxj; Tue, 1 Jun 2021 04:07:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwdnFkjMT5NPJG+7ucZ163RCaBn29vYQ/g9CNwwnht1VII4K8zeaLTDsSBqrdZ1LyN2Qqux X-Received: by 2002:a92:c087:: with SMTP id h7mr1722868ile.293.1622545668309; Tue, 01 Jun 2021 04:07:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545668; cv=none; d=google.com; s=arc-20160816; b=PqHPFknl72ectgPUnJ3QIxzp1uFwiHuG+zKLxWapF4M+AV5uRAZbqBQDOwAh+tDGs1 iC10/cT3RkAu/h2LjBCWIxVtDuC+Y+b6rRMP5GasnsbROSCuiACa1/EITyfNgkwwVjNt qXX25Rnc9kMk4nG6/rTPJSX9cUdBHxFqTapwaSjhJXgh5L0QgVlF4u6fln2iYdSNEa+N C0KaQkmvBOD6ZNaEATIMDgjbdf8dZsI32Oyv3S6Hglv6KeYtns33wFRaEjizxSGfIsC+ arG3JIJM8/zdnaiHS8fSPr99phc/3rCAAjpKVvU2C7RgloAsuejAkPUCeify0AyC/yxg 6RcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=OTZD8NGFlKmkKAdXlsXm30+ciYoLjV+iSvO1+cIEISs=; b=WWaEkjtMhLdGhOx/dv/kXHr2uOZXHfWF/6XircWz0Pm9eW9Pjw8EjxCuHeqC9fkDZz 2fpH4ECfGlqUmi8hA3Imum0qU1Mk4FZVJMLe7rRbpQn9VLHS3ksfZ1pJeZu6CmO4Hl0I AtCo0kwmibLSjOMo5EDDOu5ez+sdRsAJ6K38E6mjOGFWYDTE/qZopawU94aqQKTmpNXB mYOKf5gD8asF1rK20hOzCep0ZR/VOzhwFIMoyHTzbe2qZ7YSNhLlkguQ/1VwOC+n6ShD kuz2qx2B/8YnsPiVkjwq/Fl7bdQKYcXcgSI3RYqnsOHlI4RQ1h9vp31zRuISrIigOeZD x7Sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v19si18087675jan.91.2021.06.01.04.07.33; Tue, 01 Jun 2021 04:07:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231918AbhFALIO (ORCPT + 99 others); Tue, 1 Jun 2021 07:08:14 -0400 Received: from out30-133.freemail.mail.aliyun.com ([115.124.30.133]:37350 "EHLO out30-133.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbhFALIL (ORCPT ); Tue, 1 Jun 2021 07:08:11 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R171e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04395;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0Uav8Pdd_1622545585; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Uav8Pdd_1622545585) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:06:29 +0800 From: Jiapeng Chong To: axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ata: libata-pmp: Fix missing error code in sata_pmp_eh_recover() Date: Tue, 1 Jun 2021 19:06:19 +0800 Message-Id: <1622545579-19345-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/ata/libata-pmp.c:980 sata_pmp_eh_recover() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/ata/libata-pmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/ata/libata-pmp.c b/drivers/ata/libata-pmp.c index ba7be3f..66985af 100644 --- a/drivers/ata/libata-pmp.c +++ b/drivers/ata/libata-pmp.c @@ -977,6 +977,7 @@ static int sata_pmp_eh_recover(struct ata_port *ap) ata_link_warn(pmp_link, "failed to disable NOTIFY (err_mask=0x%x)\n", err_mask); + rc = -EINVAL; goto pmp_fail; } } -- 1.8.3.1