Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3381829pxj; Tue, 1 Jun 2021 04:08:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnQs8dQpWSs1kbDcM/4wvv2kVeJSwvt3QvaaKEJevs6rkMnwAspynZnbvi7pihcZC0hzYi X-Received: by 2002:aa7:d853:: with SMTP id f19mr31899645eds.371.1622545692371; Tue, 01 Jun 2021 04:08:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545692; cv=none; d=google.com; s=arc-20160816; b=nSCIp+1s9aWUAL+Aq/yqlWC6b0HTIhrsoWwC8XHELNOJwcQlg4Norbh0ZQh2wqnOmo OAmawF85+Ufo0suU2sINVdiJ2nBOWlm0JRhX9kAPu9WqBMFxgKdGndT4s2R8dJP8bWjB RYRt21G8seBMvb2XNpdqLYC+M1lRwAdeze6SGIMZVy0E+p3e2NBl46rKxdWZrdvfU7fu mpjC8lVnbl1rRLGt8HafzftLrzPpKEqgDLYdqf3SDb0WWo+HH03nya/afkVvCKtkJf5d +lsawvYT4oIxPXefumb+PdfS/WQiDVYmE4oswG3vnL+oau05HOlbDSsjKgpuE4NLsBSQ 16aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=e7lZlTirZHH8SUAvWLg6TzXI/74IjeHdp80P1XZWa8w=; b=nw7hWKDgIOd+IYHVw63ZTNG7KvUOAO/uU1f5J0/eLoqk73FOwtneBmfUdA0yLy9tb/ d/aYa65VAN+RB7J7YEZTTm4FIm7hNRLe3WIaDLSB2VGNC3yTrJCA6YeMRMCmnoPZnLqM gh0J90bY4O6umvNJUzyauywOVr7ZVmBwOHSM1tBhGvOnPCe+j8MZnXmzg7Y9yBkKlv1a NCGtGsq40JZGDfZ+E4fowVw2QxNVlVyVxxrfrdty0q18IKBDZdcWNTmFsfvM0OQiGAqI kqoqKTMFn++17wrX3DxYSwFtaDDfUhxKpyhOrZCfT5eCfrzkT/yyi6ok+us24Whj0cij rfkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c22si8308479eja.30.2021.06.01.04.07.48; Tue, 01 Jun 2021 04:08:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231201AbhFALHv (ORCPT + 99 others); Tue, 1 Jun 2021 07:07:51 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:54392 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231219AbhFALHu (ORCPT ); Tue, 1 Jun 2021 07:07:50 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R581e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=9;SR=0;TI=SMTPD_---0UavSAwh_1622545559; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UavSAwh_1622545559) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:06:06 +0800 From: Jiapeng Chong To: keescook@chromium.org Cc: anton@enomsg.org, ccross@android.com, tony.luck@intel.com, james.morse@arm.com, bp@alien8.de, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ACPI: APEI: ERST: Fix missing error code in erst_init() Date: Tue, 1 Jun 2021 19:05:53 +0800 Message-Id: <1622545553-19160-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/acpi/apei/erst.c:1114 erst_init() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/acpi/apei/erst.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c index 242f3c2..492d499 100644 --- a/drivers/acpi/apei/erst.c +++ b/drivers/acpi/apei/erst.c @@ -1110,9 +1110,10 @@ static int __init erst_init(void) status = acpi_get_table(ACPI_SIG_ERST, 0, (struct acpi_table_header **)&erst_tab); - if (status == AE_NOT_FOUND) + if (status == AE_NOT_FOUND) { + rc = -EINVAL; goto err; - else if (ACPI_FAILURE(status)) { + } else if (ACPI_FAILURE(status)) { const char *msg = acpi_format_exception(status); pr_err("Failed to get table, %s\n", msg); rc = -EINVAL; -- 1.8.3.1