Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3382163pxj; Tue, 1 Jun 2021 04:08:38 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzWdpA2X+UQQVdkDO6/at/UZ2sNMkEi54mWKZdTSCyfo+6qOCGDX/5uG6NYaUWm8YwJZsJR X-Received: by 2002:a05:6402:368:: with SMTP id s8mr16332126edw.129.1622545718075; Tue, 01 Jun 2021 04:08:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545718; cv=none; d=google.com; s=arc-20160816; b=D6JjobRLJAHjG/caPhZxrES5RLK21crNMOh9BYVED8LX/FOQio5vcyGX4CmZyz1tdc Ozj5scJhsildqFlOtph1VOqHFeoar6kiM8D72pBUFwyKn/Qk6W5GqMitLG1Q/h4prmK/ rGrrRxvXyaPREidSCz4PdWuTAjdtmhjhj2qm0SycIn79OjaN5Lye0yJJGVrPSMLkgzU3 CoZRJbNShCh6kULFSc5E1fQJmZtN7AmfB55BAu8NFOyVQNGq4pCXol9xv9LyGdja70ye bRCp4NOVWXB7hbfO4ingg+fohKnqeQ7saRX7SD8cmq+I+J+vnJ6c+nUVNizCd7yUo8cL m2XQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=KT6+nfYMTH7zwhHxinFuAOS2yaSfSdsgBVDyUl7jwFw=; b=KjEXOIYwQRNPDJgq21t04RMq9UJGQDYSP8A6Xrjcubn2xxrB5NmmhNL2nN7MZEcZ3l Y2sjg4H6hPR3w6xGL6WHJ3pzBkGj6F1a+NDeEogSAVsBbZT+w3JmKSSLzdzW4W86MjXh mjboSJ1HPzB5YY1ubk+CmV58Y1IifCFY5NF8xz0Hf+ZlEgBkJ+rglVids4J09zbGl2bD ujZN704kUoe8TLA7QIl9pvmPRdiP+4MZgMjTr92rWw69AhtKPBIulwEWEnlqSB1ch7zG BOXOQeW6Kksrlftb7S3kuAqHxG3tfTEUgHjgvUmMOA7nUI1HQmtRIGuLAOs+PFyoBw9V J1MA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si12031985edi.397.2021.06.01.04.08.14; Tue, 01 Jun 2021 04:08:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233541AbhFALGs (ORCPT + 99 others); Tue, 1 Jun 2021 07:06:48 -0400 Received: from out30-44.freemail.mail.aliyun.com ([115.124.30.44]:44792 "EHLO out30-44.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233509AbhFALGr (ORCPT ); Tue, 1 Jun 2021 07:06:47 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R381e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UavjINc_1622545498; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UavjINc_1622545498) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:05:04 +0800 From: Jiapeng Chong To: christopher.lee@cspi.com Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] ethernet: myri10ge: Fix missing error code in myri10ge_probe() Date: Tue, 1 Jun 2021 19:04:51 +0800 Message-Id: <1622545491-18706-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'status'. Eliminate the follow smatch warning: drivers/net/ethernet/myricom/myri10ge/myri10ge.c:3818 myri10ge_probe() warn: missing error code 'status'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c index c84c8bf..fc99ad8 100644 --- a/drivers/net/ethernet/myricom/myri10ge/myri10ge.c +++ b/drivers/net/ethernet/myricom/myri10ge/myri10ge.c @@ -3815,6 +3815,7 @@ static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent) dev_err(&pdev->dev, "invalid sram_size %dB or board span %ldB\n", mgp->sram_size, mgp->board_span); + status = -EINVAL; goto abort_with_ioremap; } memcpy_fromio(mgp->eeprom_strings, -- 1.8.3.1