Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3382360pxj; Tue, 1 Jun 2021 04:08:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwbs7PhXeOJmg+wXVorMjVWFGSQ1xWqJZvDtlVp4bEyQZQ7Fmo/3NkG+maGOipW4l6W8s/A X-Received: by 2002:a05:6e02:ca8:: with SMTP id 8mr7807607ilg.115.1622545734580; Tue, 01 Jun 2021 04:08:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545734; cv=none; d=google.com; s=arc-20160816; b=li8RKL3kb6JrQLixUunefSQ+q1CbH2FNaefd8zYRb7jb8/9NQThYei2eLPSvG+VoYy YmKiCMG8xzXVdL28RsisRRrk2txWQGSG/IJMaoBDSTWySsV0yP7HFhWyoVw+D7gAKl2d n7skR+Y8YptLWRaT5RFAjzET/eGZ71tcd4TZQ6IoS+Fg03CoGI6yuZ31XNmJzypoKzY3 t3pfZTfEdhdi6FzGnlKimOgXLZ5a17QZdSLvg8ihU32pVMVQg0p3SBV56u1kNYn079tb 8dfeyxQ8Cfi9JsrGBxbY/oTfRsGXI9hbbAcCWAWSjInXfVDb1Xf2P3ZQigiHjhO2p7yO LLHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=a4DcyJbRA7mo2crsk/v08k+1vfy25p9hvQOhIVf7bYU=; b=cLXQENNJQqiDz5e6Knxha+K3xRUdOzR1OAXEju6k35WMkACtGHu7Zh7LEijvxJ5NmI 0OB2ElFgW9pb0Tew5GFNXewE0gNfAY0ctGFiM6DC4WKdmykiiq3weNzuVwTPvJYgoDft uXp1KCOPqfc4yOmS1bTDHnLLKht4lRU2cP1o+MEf6DZWFQ3EvHlHFtfC0NuGUqxQtAd5 /TUsDTwBqvXxR76ylLeH8sqqbp/K92hzGdocGQ1LhdhziembkOwscE1E7kD3yDBeZvtd oZMzjp/NvznnGekJErSefmZqSfXHlUbZJ6CMUybJO75q9M096IBXskQ9Sc5TNHH7kmcz g6jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f4si18518143ilq.138.2021.06.01.04.08.39; Tue, 01 Jun 2021 04:08:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233336AbhFALJJ (ORCPT + 99 others); Tue, 1 Jun 2021 07:09:09 -0400 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:36433 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbhFALJI (ORCPT ); Tue, 1 Jun 2021 07:09:08 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=4;SR=0;TI=SMTPD_---0UawU1ts_1622545642; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UawU1ts_1622545642) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:07:26 +0800 From: Jiapeng Chong To: shaggy@kernel.org Cc: jfs-discussion@lists.sourceforge.net, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] fs/jfs: Fix missing error code in lmLogInit() Date: Tue, 1 Jun 2021 19:07:10 +0800 Message-Id: <1622545630-19745-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc. Eliminate the follow smatch warning: fs/jfs/jfs_logmgr.c:1327 lmLogInit() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- fs/jfs/jfs_logmgr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 9330eff21..78fd136 100644 --- a/fs/jfs/jfs_logmgr.c +++ b/fs/jfs/jfs_logmgr.c @@ -1324,6 +1324,7 @@ int lmLogInit(struct jfs_log * log) } else { if (!uuid_equal(&logsuper->uuid, &log->uuid)) { jfs_warn("wrong uuid on JFS log device"); + rc = -EINVAL; goto errout20; } log->size = le32_to_cpu(logsuper->size); -- 1.8.3.1