Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3383074pxj; Tue, 1 Jun 2021 04:09:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwf29pZSarGvBuT+0aKJmWTRlz35hamgGSKrySi3otFl3UhUOoPEIeLA+VUBiRHdc3Q5Rjg X-Received: by 2002:a05:6602:2c83:: with SMTP id i3mr7805208iow.152.1622545787039; Tue, 01 Jun 2021 04:09:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545787; cv=none; d=google.com; s=arc-20160816; b=FChDrxOwjoNIgiBcDHa27WV8deN/nIS3RmP+uZ4U1FIv6lK2DjQ13K18fXj07i3i2G 99cuU1x7ypz6IW4A5wixf7JpAPCrJzTs9ay5i5P2XymlNBjjbvhhc0CBdCNPjo2BJ1x2 /pXCJm1umFy7+G+2tW77/9702yrxKugUzEX05HVIiFwGKXmepu2qu5WK7dik2VPA8RcA W51wxeNLJHRTFrvC3kL8/x8ItPj3P3btXUmQeJeKjyjuy1IZFZqoGHpEBX8dIrIEHp2x nSDkpAKlViV4gyba/8Jlu8T8k4JfNDhKx4WejTJJaue13oCSyZL5O9JGbF/Q8htUx0z8 WDXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=dj9lboh28M1vtNB7DJSppVjsdZJqxjGybquL7P5sm64=; b=GEa+byvsqOnX31uEJWYfwpan+CjLEVrN/vcN8U+65OlRytgev8NiiIFxYDtYmgvjSI 8I/DroZiy0BjJaDUjSLDgc7203Fx62U5ilZFfaV8ftcHIhA20MmZQxPDLJOceoAoe58J 49xFzXIrQTPsl+s+Ua9hK/rJ1+NVT2PgUWZybebxizEYSwQMouUebICJ7Ef3Im8beht0 o/tFkT7lK8AkweSr6BQQ5rskbuZFH1BQMJDY99BWQqicfarH2kTqwoYqzdgnE3TaiJL6 p2hIw7P5rWJNhNWnkNpW8/o6Na0vt+nJimo+cqnIUyewOVgbL+Vlk2NcOFfNHTKaB8u4 hXzg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id m17si8904478jap.92.2021.06.01.04.09.33; Tue, 01 Jun 2021 04:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233718AbhFALIp (ORCPT + 99 others); Tue, 1 Jun 2021 07:08:45 -0400 Received: from out30-43.freemail.mail.aliyun.com ([115.124.30.43]:44892 "EHLO out30-43.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233299AbhFALIj (ORCPT ); Tue, 1 Jun 2021 07:08:39 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R421e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=7;SR=0;TI=SMTPD_---0Uaw9rLl_1622545613; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Uaw9rLl_1622545613) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:06:56 +0800 From: Jiapeng Chong To: ecree.xilinx@gmail.com Cc: habetsm.xilinx@gmail.com, davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] sfc-falcon: Fix missing error code in ef4_reset_up() Date: Tue, 1 Jun 2021 19:06:42 +0800 Message-Id: <1622545602-19483-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'rc'. Eliminate the follow smatch warning: drivers/net/ethernet/sfc/falcon/efx.c:2389 ef4_reset_up() warn: missing error code 'rc'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/net/ethernet/sfc/falcon/efx.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/sfc/falcon/efx.c b/drivers/net/ethernet/sfc/falcon/efx.c index 5e7a57b..d336c24 100644 --- a/drivers/net/ethernet/sfc/falcon/efx.c +++ b/drivers/net/ethernet/sfc/falcon/efx.c @@ -2385,8 +2385,10 @@ int ef4_reset_up(struct ef4_nic *efx, enum reset_type method, bool ok) goto fail; } - if (!ok) + if (!ok) { + rc = -EINVAL; goto fail; + } if (efx->port_initialized && method != RESET_TYPE_INVISIBLE && method != RESET_TYPE_DATAPATH) { -- 1.8.3.1