Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3383078pxj; Tue, 1 Jun 2021 04:09:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxILR5WimKhEpPXTgrqy2XoG+fJVnEc25lo0OthH1b57OXSVWAzTWBb6DcaAzSWkwfI9p9G X-Received: by 2002:a17:906:2d51:: with SMTP id e17mr6550206eji.500.1622545787112; Tue, 01 Jun 2021 04:09:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622545787; cv=none; d=google.com; s=arc-20160816; b=snvZZpu/Osyln00dsuIw561i/SE9XUfhSLOETqMVc3VIdgTE8JCEZooSEVcVwZ951C CwJJObD+SJAxV13QgwWNHAATytvGwLEuSBznWGLHyKLCO1WWM3f1uklFvwNFaPYDV3Uw M3k73w5Bm7Dhk+802mU/OXJgxTSm4GhnzGU1JdbRh5YWx2Vkc+b4jirqPXcl5jGaBx9J KgTbnn76D4wLUxy0nEdT2TwkH+M8RI72ihshlsN4ldJPBKWT235qcKY8Gd8ENE6+ugyY oJtcFRbl1Te/jCdhLqI84aj9ias2O3KOG8ukJIY4a9TJnhq8IQOiAFmihAM9+EIsLYU1 SS7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=wZ1LKQE0ex+BfTtOI7Xiw1qpiFS3US9tWlFGmrRWYD8=; b=eZkZLtiYX27R9JDHZL9TSEoz71vdLCfrgW0JAysS3UsUB8VBtsFKkJwjdBooF6OCuS CGTYobzanKjftRjlsgoO4Wml+MTYepxYM7NPZBQMnE2K/GrfG6Ob7UqtatFIyH6nxPGb 9MJ6zBsC0pfuGqCXlrNfsC6rNcdmQvLglheHvKxFUdQgTPTjDiXxDbhD0Hs5orks+PjT C7nX/0vqDrhxm+U2oiGF9mLkYHlq1WwJ/lZ6aa3GkxJxpJBitOLFU3Jmu0B1thxLkb7M ACLkXuVdzsH5K/A4j51sAZ5IPLeBACDgLHHkSZEBnXWMPcpQcAX+eVIe/ypPRaHj1+/4 hZSQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id j23si6779015eje.551.2021.06.01.04.09.24; Tue, 01 Jun 2021 04:09:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233577AbhFALJ7 (ORCPT + 99 others); Tue, 1 Jun 2021 07:09:59 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:7433 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231726AbhFALJ6 (ORCPT ); Tue, 1 Jun 2021 07:09:58 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R111e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0Uaw9rV6_1622545681; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0Uaw9rV6_1622545681) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:08:05 +0800 From: Jiapeng Chong To: bharat@chelsio.com Cc: dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] RDMA/cxgb4: Fix missing error code in create_qp() Date: Tue, 1 Jun 2021 19:07:49 +0800 Message-Id: <1622545669-20625-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. Eliminate the follow smatch warning: drivers/infiniband/hw/cxgb4/qp.c:298 create_qp() warn: missing error code 'ret'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/infiniband/hw/cxgb4/qp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index d109bb3..c940374 100644 --- a/drivers/infiniband/hw/cxgb4/qp.c +++ b/drivers/infiniband/hw/cxgb4/qp.c @@ -295,6 +295,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, if (user && (!wq->sq.bar2_pa || (need_rq && !wq->rq.bar2_pa))) { pr_warn("%s: sqid %u or rqid %u not in BAR2 range\n", pci_name(rdev->lldi.pdev), wq->sq.qid, wq->rq.qid); + ret = -EINVAL; goto free_dma; } -- 1.8.3.1