Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3393028pxj; Tue, 1 Jun 2021 04:23:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw61G1x1s/PmSVIZFp5gxRBf9lnxf6tHzzUd8q7NfbymeH/XLKv0RfOLNJoegyUOSqzgOT1 X-Received: by 2002:a17:906:9706:: with SMTP id k6mr15620618ejx.456.1622546582103; Tue, 01 Jun 2021 04:23:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622546582; cv=none; d=google.com; s=arc-20160816; b=yDa7Q72fQlus1Tv00o8Z8aWQ8Wn7Fvd+EqfWOn30SQrAFKxy9KiI0Bk6akScBwQ2c9 T4vulsdSE3b3vuIWc9LDxIjJqHYPu5B/S0ApgWet7vP/O46jNrcBezOvKzNMQ0B4uJGJ q3LoZFyDfkdpJg8FU5sijXE2wH4+hcCTy13JsF3XlGbXIZd1jz5Z4i4TwEwaQVSJThi3 PxMe0sWpawc55kgJhdPhVSCGKPn0qmh1uN90XjfCH46sRxLoWARBppMWQWLiD47aWBGv LKFSwLmgPgWUbpGRffnvnT0QJKEyMkTVNHp44aH5OueFdD8i+XI5zjkBbCHOJSYwmmeV MgvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:subject:cc:to:from; bh=9sBYe4zpb7fwHgyZs5FUw58Wumb7piiS/0knLriVGLk=; b=oUsjLsRmc91MO0/VBWVnOxKQHcVZx0FXx3G/22nXLdacavw1RRkNL3DqpoJTRqLNdy avF7fI40zpet7W8Rtp2e4aCUCxft2qgkh6/kBJtAxu04ehsK/2EJNnHxrUdLpl0ArW7+ T0Dfv6qOF5re1buV+SQBB0I7MSAQ4JjKGOv9ZU3yTFNOuEiUC683kreZZIW/+t1PXfF/ AMdsp80Va8S+/NcNcNlUVd/ADWNM1SsVOgA5VuNVqBTQQ04FAB3UPx8cYb6LFub5ukJw /uMsrXPGTYdT2ODz46rRLYG8I0/qv3DlP+/UkeypvEQ19g42pw6m4/DRRAZYUIzdaq9B CFHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v21si12031985edi.397.2021.06.01.04.22.35; Tue, 01 Jun 2021 04:23:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233628AbhFALHQ (ORCPT + 99 others); Tue, 1 Jun 2021 07:07:16 -0400 Received: from out4436.biz.mail.alibaba.com ([47.88.44.36]:46918 "EHLO out4436.biz.mail.alibaba.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbhFALHN (ORCPT ); Tue, 1 Jun 2021 07:07:13 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04423;MF=jiapeng.chong@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0UawU1dh_1622545524; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:jiapeng.chong@linux.alibaba.com fp:SMTPD_---0UawU1dh_1622545524) by smtp.aliyun-inc.com(127.0.0.1); Tue, 01 Jun 2021 19:05:30 +0800 From: Jiapeng Chong To: jikos@kernel.org Cc: benjamin.tissoires@redhat.com, linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Jiapeng Chong Subject: [PATCH] HID: usbhid: hid-pidff: Fix missing error code in hid_pidff_init() Date: Tue, 1 Jun 2021 19:05:18 +0800 Message-Id: <1622545518-18949-1-git-send-email-jiapeng.chong@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'error'. Eliminate the follow smatch warning: drivers/hid/usbhid/hid-pidff.c:1297 hid_pidff_init() warn: missing error code 'error'. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- drivers/hid/usbhid/hid-pidff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c index ea126c5..731b49e 100644 --- a/drivers/hid/usbhid/hid-pidff.c +++ b/drivers/hid/usbhid/hid-pidff.c @@ -1294,6 +1294,7 @@ int hid_pidff_init(struct hid_device *hid) pidff->pool[PID_DEVICE_MANAGED_POOL].value[0] == 0) { hid_notice(hid, "device does not support device managed pool\n"); + error = -EINVAL; goto fail; } -- 1.8.3.1