Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v16 06/14] s390/vfio-ap: refresh guest's APCB by filtering
 APQNs assigned to mdev
To:     Halil Pasic <pasic@linux.ibm.com>
Cc:     linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
        kvm@vger.kernel.org, jjherne@linux.ibm.com, freude@linux.ibm.com,
        borntraeger@de.ibm.com, cohuck@redhat.com, mjrosato@linux.ibm.com,
        alex.williamson@redhat.com, kwankhede@nvidia.com,
        fiuczy@linux.ibm.com
References: <20210510164423.346858-1-akrowiak@linux.ibm.com>
 <20210510164423.346858-7-akrowiak@linux.ibm.com>
 <20210524181548.4dbe52bc.pasic@linux.ibm.com>
From:   Tony Krowiak <akrowiak@linux.ibm.com>
Message-ID: <25ddf7f5-3d70-7e9d-14b1-76f753e64d00@linux.ibm.com>
Date:   Tue, 1 Jun 2021 07:25:55 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.1
MIME-Version: 1.0
In-Reply-To: <20210524181548.4dbe52bc.pasic@linux.ibm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk


On 5/24/21 12:15 PM, Halil Pasic wrote:
> On Mon, 10 May 2021 12:44:15 -0400
> Tony Krowiak <akrowiak@linux.ibm.com> wrote:
>
>> @@ -1601,8 +1676,10 @@ void vfio_ap_mdev_remove_queue(struct ap_device *apdev)
>>   	mutex_lock(&matrix_dev->lock);
>>   	q = dev_get_drvdata(&apdev->device);
>>   
>> -	if (q->matrix_mdev)
>> +	if (q->matrix_mdev) {
>>   		vfio_ap_mdev_unlink_queue_fr_mdev(q);
>> +		vfio_ap_mdev_refresh_apcb(q->matrix_mdev);
>> +	}
>>   
>>   	vfio_ap_mdev_reset_queue(q, 1);
>>   	dev_set_drvdata(&apdev->device, NULL);
> At this point we don't know if !!kvm_busy or kvm_busy AFAICT. If
> !!kvm_busy, then we may end up changing a shadow_apcb while an other
> thread is in the middle of committing it to the SD satellite. That
> would be no good.

No, that would not be a good thing, we should check for
that.

>
> Regards,
> Halil