Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1622467801-30957-1-git-send-email-herbert.tencent@gmail.com> <91999e12-a7de-ad4b-72c4-2376ac682c92@linux.alibaba.com>
In-Reply-To: <91999e12-a7de-ad4b-72c4-2376ac682c92@linux.alibaba.com>
From:   hongbo li <herbert.tencent@gmail.com>
Date:   Tue, 1 Jun 2021 21:04:35 +0800
Message-ID: <CABpmuw+NHufb5rV3POpuwBOyfe7few=oDG2CpOPCk0=zhXya6Q@mail.gmail.com>
Subject: Re: [PATCH] crypto: sm2 - fix a memory leak in sm2
To:     Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc:     "open list:ASYMMETRIC KEYS" <keyrings@vger.kernel.org>,
        linux-crypto@vger.kernel.org,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Eric Biggers <ebiggers@kernel.org>,
        David Howells <dhowells@redhat.com>, jarkko@kernel.org,
        =?UTF-8?B?aGVyYmVydGhibGko5p2O5byY5Y2aKQ==?= 
        <herberthbli@tencent.com>,
        open list <linux-kernel@vger.kernel.org>,
        stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Tianjia,

Tianjia Zhang <tianjia.zhang@linux.alibaba.com> =E4=BA=8E2021=E5=B9=B46=E6=
=9C=881=E6=97=A5=E5=91=A8=E4=BA=8C =E4=B8=8A=E5=8D=8810:54=E5=86=99=E9=81=
=93=EF=BC=9A
>
> Hi Hongbo,
>
> On 5/31/21 9:30 PM, Hongbo Li wrote:
> > From: Hongbo Li <herberthbli@tencent.com>
> >
> > SM2 module alloc ec->Q in sm2_set_pub_key(), when doing alg test in
> > test_akcipher_one(), it will set public key for every test vector,
> > and don't free ec->Q. This will cause a memory leak.
> >
> > This patch alloc ec->Q in sm2_ec_ctx_init().
> >
> > Fixes: ea7ecb66440b ("crypto: sm2 - introduce OSCCA SM2 asymmetric ciph=
er algorithm")
> > Signed-off-by: Hongbo Li <herberthbli@tencent.com>
> > Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
> > ---
> >   crypto/sm2.c | 24 ++++++++++--------------
> >   1 file changed, 10 insertions(+), 14 deletions(-)
> >
>
> Just add Cc: to SOB, like this:
>
>    Fixes: ea7ecb66440b (...)
>    Signed-off-by: Hongbo Li <herberthbli@tencent.com>
>    Cc: stable@vger.kernel.org # v5.10+
>    Reviewed-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
>
> Thanks,
> Tianjia

Thank you, I will resend the patch.
Hongbo