Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210601100256.70030-1-tongtiangen@huawei.com> <DBBPR04MB7930A304416458880D69E1C7873E9@DBBPR04MB7930.eurprd04.prod.outlook.com>
In-Reply-To: <DBBPR04MB7930A304416458880D69E1C7873E9@DBBPR04MB7930.eurprd04.prod.outlook.com>
From:   Fabio Estevam <festevam@gmail.com>
Date:   Tue, 1 Jun 2021 11:04:21 -0300
Message-ID: <CAOMZO5CKW5n4P9X5tTHGcS-MkN=gmCkyS1+bkwn98kaK2vL3-w@mail.gmail.com>
Subject: Re: [PATCH -next] soc: imx: gpc: add check for of_match_device in imx_gpc_old_dt_init
To:     Jacky Bai <ping.bai@nxp.com>
Cc:     Tong Tiangen <tongtiangen@huawei.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        Pengutronix Kernel Team <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 1, 2021 at 7:11 AM Jacky Bai <ping.bai@nxp.com> wrote:

> I think there is no chance to pass 'invalid of_id' and 'of_id_data' to the probe function.
> Such check seems not really necessary.

I agree. The only way this driver can probe is via device tree.