Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3516527pxj; Tue, 1 Jun 2021 07:08:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxwSn6f2tZvLcJTjF4EcetDyrfWr3CmcPSdz/L0/wvnVzz8yhMWrtURsUQvDubfr6XhQomb X-Received: by 2002:a92:2a05:: with SMTP id r5mr667028ile.69.1622556521648; Tue, 01 Jun 2021 07:08:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622556521; cv=none; d=google.com; s=arc-20160816; b=nyO8LMlpcfRp55N8D86rOgvw8ekETk/+xjdF9GL4VaxxKDnt1jP80xpr4JyZh1q/kY HVbMvL0kfA3hZhzFrbLyHak364D3hn0HEBfvi5s7tg0y5OnfQ189hM6zu/VBGzEts2ex Hzl80Gzm776dhMUVExqGgg5lffRyZUYDgzeMniguaox2b8+apmBmSJTLjYH65sbuwe87 kX2bBQ8q7Gj/wGOexdQ4jtFdztt9ZMMkW7/v5ZPBF8dY6Lj1mwKIZdvDMbevlrYs9H6Y w1byu76hXfkr1ghDwdCSbKKgEqwNlGEUiL7FPcT/M7+1cW9zYYoBm5cE74lZdroaYrOJ hA/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=V/Gy4/aTskAUW1dhmbnro9Db0gvQ9L6UWgclTRyoBxE=; b=fc26rl1Kj/PxJ3jvI1udZj46ZVrpQady+zURDwPbDgVJTJ6OL0j7vwtyHp2HYl8fJx JbX9K+3ct4vXv2LpWTyrAMmwgvi0IBgh0USTABmfz9xGiNgQe8rxQ9dgRTzD72faESRi zeeeYriMwr4sjJQsN8e3zngPTUxePHWJ6WFST1Kks355b8/h68WFMMtWe12OhXDrQCDl CvK0i3lI9jj2en0R7GOQbnna+8+vQOaO0ESnSwg4tGVSaYtjIzC4GOrFKW5UAK+et6Zq Y+fMnYjOENeLf8MFuBgKQQ1Z6GYKQSVBnph0c4JFHAwtItnaIzysBR/rOZLCMc0hfSRH uq0A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z13si10737420ilm.140.2021.06.01.07.08.25; Tue, 01 Jun 2021 07:08:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234220AbhFAOHr (ORCPT + 99 others); Tue, 1 Jun 2021 10:07:47 -0400 Received: from szxga02-in.huawei.com ([45.249.212.188]:2934 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234271AbhFAOHh (ORCPT ); Tue, 1 Jun 2021 10:07:37 -0400 Received: from dggeme760-chm.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4FvYlP59FMz68dp; Tue, 1 Jun 2021 22:02:57 +0800 (CST) Received: from localhost.localdomain (10.175.104.82) by dggeme760-chm.china.huawei.com (10.3.19.106) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Tue, 1 Jun 2021 22:05:53 +0800 From: Zheng Yongjun To: , , , CC: , , Zheng Yongjun Subject: [PATCH -next] scsi: bfa: Remove unneeded if-null-free check Date: Tue, 1 Jun 2021 22:19:33 +0800 Message-ID: <20210601141933.4131855-1-zhengyongjun3@huawei.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.104.82] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggeme760-chm.china.huawei.com (10.3.19.106) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Eliminate the following coccicheck warning: drivers/scsi/bfa/bfad_debugfs.c:375:2-7: WARNING: NULL check before some freeing functions is not needed. Signed-off-by: Zheng Yongjun --- drivers/scsi/bfa/bfad_debugfs.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/bfa/bfad_debugfs.c b/drivers/scsi/bfa/bfad_debugfs.c index fd1b378a263a..5e419945c6e2 100644 --- a/drivers/scsi/bfa/bfad_debugfs.c +++ b/drivers/scsi/bfa/bfad_debugfs.c @@ -371,9 +371,7 @@ bfad_debugfs_release_fwtrc(struct inode *inode, struct file *file) if (!fw_debug) return 0; - if (fw_debug->debug_buffer) - vfree(fw_debug->debug_buffer); - + vfree(fw_debug->debug_buffer); file->private_data = NULL; kfree(fw_debug); return 0; -- 2.25.1