Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 1 Jun 2021 09:20:47 -0600
From:   Mathieu Poirier <mathieu.poirier@linaro.org>
To:     Zhihao Cheng <chengzhihao1@huawei.com>
Cc:     ohad@wizery.com, bjorn.andersson@linaro.org,
        linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
        yukuai3@huawei.com
Subject: Re: [PATCH] remoteproc: pru: Remove redundant dev_err call in
 pru_rproc_probe()
Message-ID: <20210601152047.GA1759269@xps15>
References: <20210601083100.130776-1-chengzhihao1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210601083100.130776-1-chengzhihao1@huawei.com>
Precedence: bulk

On Tue, Jun 01, 2021 at 04:31:00PM +0800, Zhihao Cheng wrote:
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zhihao Cheng <chengzhihao1@huawei.com>
> ---
>  drivers/remoteproc/pru_rproc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/pru_rproc.c b/drivers/remoteproc/pru_rproc.c
> index e5778e476245..6491c731c6e2 100644
> --- a/drivers/remoteproc/pru_rproc.c
> +++ b/drivers/remoteproc/pru_rproc.c
> @@ -822,8 +822,6 @@ static int pru_rproc_probe(struct platform_device *pdev)
>  						   mem_names[i]);
>  		pru->mem_regions[i].va = devm_ioremap_resource(dev, res);
>  		if (IS_ERR(pru->mem_regions[i].va)) {
> -			dev_err(dev, "failed to parse and map memory resource %d %s\n",
> -				i, mem_names[i]);

https://patchwork.kernel.org/project/linux-remoteproc/patch/20210511120426.5834-1-thunder.leizhen@huawei.com/

>  			ret = PTR_ERR(pru->mem_regions[i].va);
>  			return ret;
>  		}
> -- 
> 2.31.1
>