Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3625442pxj; Tue, 1 Jun 2021 09:24:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwKk+mgOsZHIqwOxgaj16zkrEM2tvFtgtZHPy8ZsVradpA5nXUVfjQQTKxYedoUhYre15Ex X-Received: by 2002:a92:c70b:: with SMTP id a11mr23165540ilp.136.1622564687732; Tue, 01 Jun 2021 09:24:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622564687; cv=none; d=google.com; s=arc-20160816; b=qtjjwxppxM5rAB7JVhZA242QmkhJ6bmS/fq5xwc7funLCF5peSPYTkVX8KKVP0pkvT 7GZ+iNPj5JVc1TLorPgVTdJ9rQb3fB0Q4HEUN1n0EIBWkoZdUKgCY3giggJb+F9AU1Au +zTBuLIyXGNNkzRbNZ4pDlHOCd4+r4qfW+QGQ1m0ve17CPh+iCY/XdB+liHfh9J43Zh9 A36LmbkEUasJCEVEwAIIv9+4/CiPN3yiZY6eAIc9bN753X9S0Phg5FEVlGBJRpK1EL8o +bIV1MF3BfY09D0hLzVF1NDLdgJQfsGB+FVyiu5bLBfNCRgbTIDskehmKZdvCfC4IS+q +a/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:ironport-sdr:ironport-sdr; bh=NHQJMJppb1mmkxPpchdIqXGNpJSXYZa7D3lcLuh+ipE=; b=i6lkUl+E2rKsswt0aD44hLfGn06Oma2Uhw/pUmaC2fE+xVqOYMlS7WaXEI1le8DLVV Al98KyLj2cLhsQJyNFak+m+Bx7EBSQKFX0/TKexGB1FQKxMAVHfLiPjOS0Xd9bpNHcR6 FM9JT35dXoCfDhjttHUtJfjDKiSjYCY7ahLR+C53ysILAYMvvDkR1faAIYNnn3/GAa2z QOmVaOUgzqvU28ZNZYtpHjDMZiyH26YWnEYeseYndpXfqBMoVLXxSk0bcln0QLPQnho9 CwrEcZFqgUfSdZjZEcW2ltcAoRr2YFA+53LRx6pTu0+iQK0DrvFnys7/sjA4CpaEHe55 Nffw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id i9si16942497ioh.53.2021.06.01.09.24.33; Tue, 01 Jun 2021 09:24:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234140AbhFAQXM (ORCPT + 99 others); Tue, 1 Jun 2021 12:23:12 -0400 Received: from mga03.intel.com ([134.134.136.65]:31283 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234127AbhFAQXL (ORCPT ); Tue, 1 Jun 2021 12:23:11 -0400 IronPort-SDR: 0XLJNVcJMBo9wAsqMitQRV4TVoG9CYbjjUUCZ+qMjceeCvKSaX0AsLGTFsODmLILztIcHyeIBJ 2q/27bjhNJgg== X-IronPort-AV: E=McAfee;i="6200,9189,10002"; a="203614077" X-IronPort-AV: E=Sophos;i="5.83,240,1616482800"; d="scan'208";a="203614077" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2021 09:21:14 -0700 IronPort-SDR: 5i7QGMfN7LM23BdaW5FLA2mGTTRGNaJ2WNUxxX0en59aaHoBQDq2fAv7mNJD2WE1/TNtALOwX5 x6eZVkyYZtHQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,240,1616482800"; d="scan'208";a="399655545" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga006.jf.intel.com with ESMTP; 01 Jun 2021 09:21:11 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 1C2A11FC; Tue, 1 Jun 2021 19:21:34 +0300 (EEST) From: Andy Shevchenko To: Andy Shevchenko , Serge Semin , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Hoan Tran , Serge Semin , Linus Walleij , Bartosz Golaszewski Subject: [PATCH v1 1/2] gpio: dwapb: Drop redundant check in dwapb_irq_set_type() Date: Tue, 1 Jun 2021 19:21:27 +0300 Message-Id: <20210601162128.35663-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For more than 15 years we may not get into ->irq_set_type() without any meaningful type provided. Drop redundant check in dwapb_irq_set_type(). See the commit e76de9f8eb67 ("[PATCH] genirq: add SA_TRIGGER support") out of curiosity. Signed-off-by: Andy Shevchenko --- drivers/gpio/gpio-dwapb.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index d3233cc4b76b..939701c1465e 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -297,9 +297,6 @@ static int dwapb_irq_set_type(struct irq_data *d, u32 type) irq_hw_number_t bit = irqd_to_hwirq(d); unsigned long level, polarity, flags; - if (type & ~IRQ_TYPE_SENSE_MASK) - return -EINVAL; - spin_lock_irqsave(&gc->bgpio_lock, flags); level = dwapb_read(gpio, GPIO_INTTYPE_LEVEL); polarity = dwapb_read(gpio, GPIO_INT_POLARITY); -- 2.30.2