Received: by 2002:a05:6a10:206:0:0:0:0 with SMTP id 6csp3756304pxj; Tue, 1 Jun 2021 12:22:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw7caiYdgseB+xBq6dHEtPxD6nEwd51mV0gr/u5zaqEGAvihUtYr+T17ZPrdC/wz2k6SIPc X-Received: by 2002:a05:6402:254d:: with SMTP id l13mr34971196edb.281.1622575376867; Tue, 01 Jun 2021 12:22:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1622575376; cv=none; d=google.com; s=arc-20160816; b=ePOmBKFFOXjCjLvkiCJcyweBJmbsN8a1Zuf28ZQ3Terd7WW8EXr4cZq4GuHmycNlR1 B9cOH0A8zNtH2kla2EfanZLTYwd2cuBjigmDBcVWOglwD/FjQunrlkSAoAYN8uXeNvtY RH1gWxjYbujRZuqpCkKNeR1nnuYQlibQkcptYwTWZ3G8txz1ZF10d2DHHCBzqJGoPJ9n ILoCal65wDA+qM+TQXeDm+zgsebT2BMD/lVKkJzUuUwKf2NNsyS/Izd/Hl/CfA3MEKJH 9SutOvhFYWkJEnTGYHHT6HW14s56XJIJTr/HlR0n7J0cQgHlYb2P+fqJIH8HKKmYtFVz XxNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=buLhPbHrFpi6KG0ErdpygLDLYcV9LBfIxFbXDWOKBP4=; b=03kh6y4+VJyAtf46UQciNKrhTsX3CpeR6k9scc/d6xh9HKCVGh1HuAcCpA3UG1/csO mIafkrhbp7s5Nb+RSOMfZU3uZ6lDbyVL51ObNpFLdMpL4ZBYl32Z0+Hp73Y3bCIv2CBa kTfL7LG5z3pHpMnkUqRUinjH39Jpqz5wOZStqScA6xBOBWts/J/J2PE9J1HcTWJIAhkO /2UTWq2/d/6uyRln3BP63vkS3Gf4ygRFvt/FAjPVwbReUw5WC+b3MC+9x92S7oiprSBa uDm2DpD2UAaD1CdS2F8Olla3z29aOVUz7rAycldgC/OuEWFRQH94yvQPl4dQoPmlu4ry 3VXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nJQJkMdF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id hq1si16382739ejc.659.2021.06.01.12.22.34; Tue, 01 Jun 2021 12:22:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=nJQJkMdF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234836AbhFATWy (ORCPT + 99 others); Tue, 1 Jun 2021 15:22:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234842AbhFATWu (ORCPT ); Tue, 1 Jun 2021 15:22:50 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18784C061574 for ; Tue, 1 Jun 2021 12:21:08 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id g18so291575pfr.2 for ; Tue, 01 Jun 2021 12:21:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=buLhPbHrFpi6KG0ErdpygLDLYcV9LBfIxFbXDWOKBP4=; b=nJQJkMdFCEKm3y3/x9E10xUE4aPzsu6vVkMeh1Y89Ap/86sznI718OOCm2FHLR7aVb MAep6R53Bjstw0NZACsB0x30q6XYaf1Gt5SBkqPn87sVXoBQLqAvA3ETFbRiz3SvxBhR Dx/kqyg1/CwpJHGPbXVmiIMAdJRxVOQl02YuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=buLhPbHrFpi6KG0ErdpygLDLYcV9LBfIxFbXDWOKBP4=; b=swrzKkuAZeZ2MzFwS2HlVhXygrLGp5t+9sQ+sefVoS0KFmAnp+T1Ji5fdCuGTpZ6dY JyI/aWV9Fy2L8PW9/V8RpPQwch0bQsUeORMhZL4BpQ9DbdIGSKq56O+fprKkjmDYCIb/ 4Ybx6ewoNTO9E6XBgi2O4+dIdi7WmY4S+q8EM3FXO2g7XztwKRPMvzOaNlTDJaljvUI2 7z0ICJdlKchChDNI1zM+2zl7UtWCd8JbtC6UFZ8pIxrqkuIWWQLLsLDb6taWfdjioK+b Xr/MJbrzdXFM4BGjbKdDd911hIlyEm3LxwoqoTKSaFKsHvoYkPoDAQtlOf+HjE4CxykU LCgg== X-Gm-Message-State: AOAM530+ZO1V76PBinbPNQCVMc+f5vrpHxdCY9P3P7fHZbYARuuKENjq BsyVCp/TzqwRacX6a1KEhYK/hg== X-Received: by 2002:a63:db01:: with SMTP id e1mr29836130pgg.38.1622575267711; Tue, 01 Jun 2021 12:21:07 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id s29sm10486657pgm.82.2021.06.01.12.21.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jun 2021 12:21:07 -0700 (PDT) Date: Tue, 1 Jun 2021 12:21:06 -0700 From: Kees Cook To: "Gustavo A. R. Silva" Cc: Sunil Goutham , Geetha sowjanya , Subbaraya Sundeep , hariprasad , "David S. Miller" , Jakub Kicinski , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH][next] octeontx2-pf: Fix fall-through warning for Clang Message-ID: <202106011221.24B746FA@keescook> References: <20210528202225.GA39855@embeddedor> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210528202225.GA39855@embeddedor> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 28, 2021 at 03:22:25PM -0500, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115 > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Kees Cook -- Kees Cook